Skip to content

StatefulModeSDecoder: only decode valid positions #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrksngl merged 2 commits into from
Mar 2, 2026
Merged

StatefulModeSDecoder: only decode valid positions #35

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7a330e
StatefulModeSDecoder: only decode valid positions
fixje Feb 26, 2026
3958a37
PositionMsg: Added note on invalid position
fixje Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/de/serosystems/lib1090/StatefulModeSDecoder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,10 @@ public ModeSDownlinkMsg decode(String raw_message, boolean noCRC, long timestamp
* @return decoded WGS84 position
*/
public Position extractPosition(ModeSDownlinkMsg.QualifiedAddress address, PositionMsg msg, Position receiver) {
if (!msg.hasValidPosition()) {
return null;
}

DecoderData dd = getDecoderData(address);
Position pos = dd.posDec.decodePosition(msg.getCPREncodedPosition(), receiver);

Expand Down
3 changes: 2 additions & 1 deletion src/main/java/de/serosystems/lib1090/msgs/PositionMsg.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ public interface PositionMsg {
boolean hasValidPosition();

/**
* @return the CPR encoded position that was announced in this message
* @return the CPR encoded position that was announced in this message.
* The method may return an invalid position if #hasValidPosition() is false.
*/
CPREncodedPosition getCPREncodedPosition();

Expand Down