Use chromedriver manager in order for less setup - #27
Merged
Conversation
Contributor
Author
|
The reason I created a new pull request for this is that #21, my old pull, is outdated and is behind many commits. I feel a smaller request such as this is more reasonable, and I may implement multiproccessing with futures some other time |
kpcyrd
reviewed
Dec 12, 2021
| from selenium.webdriver.support.ui import Select | ||
|
|
||
| from webdriver_manager.chrome import ChromeDriverManager | ||
| os.environ['WDM_LOG_LEVEL'] = '0' |
There was a problem hiding this comment.
This should by passed through the constructor instead:
ChromeDriverManager(log_level=0)https://github.com/SergeyPirogov/webdriver_manager#wdm_log_level
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses a library called
webdriver-managerwhich allows the installation of a chromedriver depending on your OS and chrome version. It saves it to cache, and will not need to reinstall each time. If there every are pull errors, this really isn't that big of a change so it can be implemented easily.