Potential fix for code scanning alert no. 8: Prototype-polluting function - #14
Merged
Merged
Conversation
…tion Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
ShadowDara
marked this pull request as ready for review
September 13, 2026 20:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/ShadowDara/finder/security/code-scanning/8
General fix: harden the deep-assignment function so recursive traversal only proceeds through safe, own container properties on the destination object, and avoid writing through dangerous property names.
Best fix here (without changing intended behavior): keep the existing blocked-key check, and additionally ensure each intermediate segment is an own property before recursing; if absent, create it with a null-prototype object (
Object.create(null)) to avoid inherited prototype behavior. If present but not a plain object, replace withObject.create(null). Before final assignment, also re-check the final key and ensure assignment target is object-like.Edit only
npm/site/src/configeditor/editor.tsx, insidesetPath(lines around 118–130). No new imports are required.Suggested fixes powered by Copilot Autofix. Review carefully before merging.