Skip to content

Potential fix for code scanning alert no. 8: Prototype-polluting function #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShadowDara merged 1 commit into from
Sep 13, 2026
Merged

Potential fix for code scanning alert no. 8: Prototype-polluting function #14

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions npm/site/src/configeditor/editor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,15 +118,26 @@ export function setupConfigEditor(
function setPath(obj: any, path: string, value: unknown) {
const parts = path.split(".");
const blockedKeys = new Set(["__proto__", "constructor", "prototype"]);
if (parts.some((part) => blockedKeys.has(part))) return;
if (parts.length === 0 || parts.some((part) => blockedKeys.has(part))) return;

let cur = obj;
let cur: any = obj;
for (let i = 0; i < parts.length - 1; i++) {
const p = parts[i];
if (typeof cur[p] !== "object" || cur[p] === null) cur[p] = {};
if (blockedKeys.has(p)) return;
if (typeof cur !== "object" || cur === null) return;

if (!Object.prototype.hasOwnProperty.call(cur, p)) {
cur[p] = Object.create(null);
} else if (typeof cur[p] !== "object" || cur[p] === null) {
cur[p] = Object.create(null);
}
cur = cur[p];
}
cur[parts[parts.length - 1]] = value;

const last = parts[parts.length - 1];
if (blockedKeys.has(last)) return;
if (typeof cur !== "object" || cur === null) return;
cur[last] = value;
}

function readField(input: any): unknown {
Expand Down
Loading