Add to_liquid_call_count feature for liquification-count specs - #163
Open
ianks wants to merge 1 commit into
Open
Add to_liquid_call_count feature for liquification-count specs#163ianks wants to merge 1 commit into
ianks wants to merge 1 commit into
Conversation
StandardFilterTest#test_default_43dbbb97 asserts that to_liquid is called
exactly twice for '{{ a0 | default }}' (Ruby liquifies in find_variable and
again in filter invoke). Engines that liquify once, or that lower 'default'
to bytecode instead of a real filter invocation (e.g. liquid-vm), observe a
different count while rendering identical output for ordinary values.
Tag the spec with a dedicated feature so such engines can declare it as a
missing feature instead of carrying it in known-failure baselines.
Assisted-By: devx/717e5259-915f-4a7b-af07-6abe46da5b90
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StandardFilterTest#test_default_43dbbb97asserts thatto_liquidis called exactly twice for{{ a0 | default }}(Ruby liquifies once infind_variableand again in filterinvoke). Engines that liquify once — or that lowerdefaultto bytecode instead of a real filter invocation (liquid-vm does this) — observe a different counter value while rendering identical output for ordinary values.This adds a
to_liquid_call_countfeature (catalog: recommendationunnecessary, same spirit asruby_drops) and tags that one spec with it, so engines can declare it as a missing feature instead of carrying the spec in known-failure baselines forever.Downstream: lets Shopify/liquid-vm drop
test/known_failures.txtto zero entries and drivetest/rust_parser_known_failures.txtto 0 (liquid-vm PR to follow).