Skip to content

Add to_liquid_call_count feature for liquification-count specs #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ianks wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add to_liquid_call_count feature for liquification-count specs #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/liquid/spec/cli/features.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,13 @@ module Features
recommendation: :unnecessary,
note: "Ruby implementation detail. Tests internal drop mechanics.",
},
to_liquid_call_count: {
description: "Tests asserting Ruby's exact to_liquid invocation count",
recommendation: :unnecessary,
note: "Ruby implementation detail. Ruby liquifies a value in find_variable and " \
"again in filter invoke; engines that liquify once (or lower filters like " \
"`default` to bytecode) legitimately observe a different count.",
},
drop_class_output: {
description: "Tests expecting drop class name in output (Liquid::Drop)",
recommendation: :unnecessary,
Expand Down
1 change: 1 addition & 0 deletions specs/liquid_ruby/standard_filters.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1211,6 +1211,7 @@ specs:
complexity: 160
features:
- ruby_drops
- to_liquid_call_count
- name: StandardFilterTest#test_default_446f9bac
template: "{{ a0 | default }}"
environment:
Expand Down
Loading