Skip to content

fix: smart alarm feature fails to fetch when application is not opened for a long period of time#33

Open
erik-keifer wants to merge 5 commits into
mainfrom
erik-keifer-patch-2
Open

fix: smart alarm feature fails to fetch when application is not opened for a long period of time#33
erik-keifer wants to merge 5 commits into
mainfrom
erik-keifer-patch-2

Conversation

@erik-keifer

@erik-keifer erik-keifer commented Apr 5, 2026 •
edited by Copilot AI
Loading

Copy link
Copy Markdown
Collaborator
  • Remove "✅ Fix:" prefix from comments to match codebase style
  • Remove trailing blank lines at end of file
  • Reintroduce InsightsStore as @StateObject and inject via .environmentObject

@erik-keifer
Update SleepFocusApp.swift
d3a8090 
Fix: refresh smart alarm guidance when app returns to foreground
@austinkimchi austinkimchi requested a review from Copilot April 5, 2026 05:46
@austinkimchi austinkimchi linked an issue Apr 5, 2026 that may be closed by this pull request
Feat: Gather user's behaviors during onboarding #9
Closed
Copilot AI reviewed Apr 5, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the app lifecycle handling to refresh smart alarm guidance when the app returns to the foreground.

Changes:

  • Observes scenePhase in SleepFocusApp and triggers a forced refresh of smart alarm guidance when the app becomes active.
  • Syncs smart alarm runtime (notifications / live activity) after the foreground refresh.
  • Removes InsightsStore wiring from the app root.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread SleepFocus/SleepFocusApp.swift
Comment thread SleepFocus/SleepFocusApp.swift Outdated
Comment thread SleepFocus/SleepFocusApp.swift Outdated
Copilot AI requested a review from austinkimchi April 5, 2026 05:52
@austinkimchi austinkimchi changed the title Update SleepFocusApp.swift fix: smart alarm feature fails to fetch when application is not opened for a long period of time Apr 5, 2026
@austinkimchi austinkimchi removed a link to an issue Apr 5, 2026
Feat: Gather user's behaviors during onboarding #9
Closed
@austinkimchi austinkimchi linked an issue Apr 5, 2026 that may be closed by this pull request
Bug: Smart Alarm feature fails to fetch when application is not opened for a long period of time #11
Open
@austinkimchi

austinkimchi commented Apr 5, 2026

Copy link
Copy Markdown
Member

@erik-keifer
How is this change going to fix #11?
The issue outlines that there's an issue with the smart alarm output not being properly calculated.
But your solution proposes to refresh the smart alarm on application launch.

  1. Note that the application is already loaded in memory and not refreshed, so this code won't be triggered.
  2. The issue outlines that there is an issue with sending requests to the backend specifically.

I believe this might have been fixed with commit 6e27cae.
I am postponing this patch until it can be further verified that it still exists.

@austinkimchi

austinkimchi commented Apr 7, 2026

Copy link
Copy Markdown
Member

@copilot, please verify if this entire issue has been addressed and fixed in the next version #39.

Copilot AI commented Apr 7, 2026

Copy link
Copy Markdown

@copilot, please verify if this entire issue has been addressed and fixed in the next version #39.

After reviewing PR #39 and commit 6e27cae, the issue described in #11 is not fixed in either:

  • Commit 6e27cae (feat: generated ai recommendation) doesn't touch the smart alarm fetch path at all.
  • PR add feat watch sleep onset detection #39 adds a new .automatic watch-based mode, but its version of SleepFocusApp.swift drops the scenePhase observer introduced in this PR — meaning the foreground-refresh fix would be lost if add feat watch sleep onset detection #39 is merged without this PR's changes.

The fix in this PR (observing scenePhase and force-refreshing smart alarm guidance when the app returns to the foreground) still targets the root cause described in #11 and is not covered elsewhere. It should be merged or rebased on top of #39.

@austinkimchi austinkimchi requested a review from Copilot April 7, 2026 18:46
Copilot AI reviewed Apr 7, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread SleepFocus/SleepFocusApp.swift
austinkimchi and others added 2 commits April 7, 2026 11:53
@austinkimchi
refresh when no other refresh is in progress
d892c4e 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@austinkimchi
Merge branch 'main' into erik-keifer-patch-2
875131d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@austinkimchi austinkimchi Awaiting requested review from austinkimchi

+1 more reviewer

Copilot code review Copilot Copilot left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@austinkimchi austinkimchi

@erik-keifer erik-keifer

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: Smart Alarm feature fails to fetch when application is not opened for a long period of time

4 participants

@erik-keifer @austinkimchi