fix: wake window not properly syncing#46
Conversation
|
Wanted to rename the branch but closes the PR. Reopened it with intent to fix wake window. |
|
This PR should have been opened with base feat-watch-wake-onset. |
austinkimchi
added
enhancement
austinkimchi
left a comment
austinkimchi
left a comment
There was a problem hiding this comment.
Needs a slight change in the logic of the allowed wake window.
From depending on fetching sleep score to depending on local HealthKit data.
| SmartAlarmWidgetBridge.writeState(state) | ||
| } | ||
|
|
||
| private func wakeWindowDisplayComponents(for nextAlarmDate: Date?, calendar: Calendar = .current) -> (earliest: String, latest: String) { |
There was a problem hiding this comment.
Currently, the wakeup time is only shown after midnight passes for the next session of sleep, as the current day for the next day's wakeup changes.
I think this needs a more complex logic, where it changes after a set time of 12:00pm (noon) or after detecting the previous night's sleep from healthkit.
There was a problem hiding this comment.
I think there is logic for this currently somewhere, but it shouldn't depend on fetching the sleep score. Instead, it should depend locally on whether the user slept (from HealthKit).
As it shows after sleep score was fetched.
2 participants
No description provided.