Repository navigation
Add an Appearance setting: follow the system, or pick a theme - #49
Merged
Merged
Conversation
The popover and every window were forced dark. Settings > Appearance now has a Theme (System, Dark, Light, Razer Green) and a Glass effect switch. The popover follows the system by default and updates live; windows follow light or dark. Solid backgrounds are painted in the popover's frame view so the arrow matches. Green text and the Bluetooth blue adapt to light mode, and selected chips use dark text on green, since white on #44D62C is only about 1.9:1.
The colour page's swatch and wheel outlines were white, which vanishes on a light popover; they now use the primary colour. The backdrop colour is returned as an NSColor from PopoverLook instead of an RGBA tuple.
Settings, About and the other windows only followed light or dark. They now get the same glass, solid background or Razer Green tint as the popover. The glass and tint sit in each window's frame view so the title bar matches.
The popover colours and PopoverLook had separate copies of the same hex to NSColor conversion; both now use NSColor(hex:). The comment boxes in the crash report and device test windows drew an opaque system background over the themed window; they now use a faint fill like the cards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The popover and every window used to be forced dark. Settings › Appearance now has:
The popover follows macOS by default and updates live, even while it's open. Settings, About and the other windows get the same look: glass or solid, light, dark or green. Only the popover gets the green edge. Razer Green is always dark.
Mockups (approved): https://claude.ai/artifact/RNsSMjXHQLcCE7QJf4KbKT
How
PopoverTheme.swift: the theme,PopoverLook.resolve(theme:glass:systemIsDark:)(one pure function for all 16 combinations),AppearanceSettings(UserDefaults, window tracking),PopoverBackdropViewandWindowBackdrop(a glass view plus the tint, in each window's frame view).razerGreenstays the fill. Green text and icons userazerGreenText(#23891A on light). Selected chips useonRazerGreen(#0D2B07) in every theme, because white on #44D62C is only about 1.9:1. The logo green and the Bluetooth blue adapt too.PopoverThemeTestscovers every combination, defaults, persistence, an unknown stored value, and window tracking.swift testpasses locally (350 tests).Please check on a real Mac (
swift run MacRazer)Not in this PR
Bordered-prominent buttons tinted green (Install Now, Permissions Grant/Relaunch/Done, Crash Report, Updated, What's New) still use the system's white label on green. Changing that means restyling those buttons, so it's left for a follow-up.
🤖 Generated with Claude Code