Switch all workflows to ubuntu-slim except GitOps#378
Conversation
| update_release_draft: | ||
| name: update release draft | ||
| runs-on: ubuntu-24.04 | ||
| runs-on: ubuntu-slim |
There was a problem hiding this comment.
I wouldn't use the slim thing here since this is on the release production path and therefore time to market will be decreased when change this.
There was a problem hiding this comment.
To my intuition this shouldn't become slower. The release-drafter action is a nodejs action which means it runs single-threaded anyway. So the switch to 1vCPU shouldn't matter 🤔 ?
If ubuntu-slim runs in a container instead of a VM we might even experience faster cold starts 🤔
This line of thinking applies to all actions you commented on.
Wdyt?
There was a problem hiding this comment.
This sounds reasonable. 👍
One thought: NodeJS allows spawning child processes which are then decoupled from the parent event loop and therefore the assumption "it's nodejs it will def. only use one CPU" is not correct.
stefanmeschke
left a comment
There was a problem hiding this comment.
We need to monitor this change ofc. 😊
From my point of view there are labels missing on this PR in order to mark this PR as major change etc.
|
Dear reviewers, thank you for the approvals. In one of our repos I switched to the slim-runner for the Linter. That made the execution time explode. This reassured me in that if we merge this PR we should keep a close eye on stuff. My capacity is limited and I personally would not like to pick this battle right now. Does anybody want to take the over here? Maybe @sbmars? |
Type of Change
Description
If you think any actions should not run in this slim version please flag it. GitOps comes to mind because building Dockerfiles might be heavy.
Checklist