Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cla.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:

jobs:
CLAssistant:
runs-on: ubuntu-24.04
runs-on: ubuntu-slim
steps:
- name: "CLA Assistant"
if: (github.event.comment.body == 'recheck' || github.event.comment.body == 'I have read the CLA Document and I hereby sign the CLA') || github.event_name == 'pull_request'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/template_autodev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
autodev:

name: Build Dev Branch
runs-on: ubuntu-24.04
runs-on: ubuntu-slim

# check to not trigger if dependabot did something or PR was closed or label is not the configured dev label
if: github.actor != 'dependabot[bot]' && (github.event_name == 'push' || github.event.label.name == inputs.label || github.event.action == 'closed')
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/template_automerge_dependabot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
dependabot:

name: auto-merge
runs-on: ubuntu-24.04
runs-on: ubuntu-slim

if: github.event.pull_request.user.login == 'dependabot[bot]'

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/template_changeset_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ jobs:
changeset-check:
name: changeset-check
if: (!contains(github.event.pull_request.user.login , '[bot]'))
runs-on: ubuntu-24.04
runs-on: ubuntu-slim
steps:
- name: Checkout code
uses: actions/checkout@v6
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/template_changeset_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ on:
jobs:
release:
name: changeset-release
runs-on: ubuntu-24.04
runs-on: ubuntu-slim
steps:
- name: Get App Token
uses: actions/create-github-app-token@v2.2.0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/template_flaky_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ on:
jobs:
flaky-tests:
name: Flaky-Tests
runs-on: ubuntu-24.04
runs-on: ubuntu-slim
steps:
- name: Find flaky tests
uses: Staffbase/github-action-find-flaky-tests@v0.3.1
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/template_jira_tagging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
jira-annotate:

name: Annotate all occurring tickets since last release-tag
runs-on: ubuntu-24.04
runs-on: ubuntu-slim

steps:
- name: Checkout
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
launchDarklyCodeReferences:

name: Find LaunchDarkly flag code references
runs-on: ubuntu-24.04
runs-on: ubuntu-slim

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/template_merge_block.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ on:
jobs:
do-not-merge:
name: Check
runs-on: ubuntu-24.04
runs-on: ubuntu-slim

steps:
- name: Find Comment
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/template_release_drafter.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ on:
jobs:
update_release_draft:
name: update release draft
runs-on: ubuntu-24.04
runs-on: ubuntu-slim
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't use the slim thing here since this is on the release production path and therefore time to market will be decreased when change this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my intuition this shouldn't become slower. The release-drafter action is a nodejs action which means it runs single-threaded anyway. So the switch to 1vCPU shouldn't matter 🤔 ?

If ubuntu-slim runs in a container instead of a VM we might even experience faster cold starts 🤔

This line of thinking applies to all actions you commented on.
Wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds reasonable. 👍
One thought: NodeJS allows spawning child processes which are then decoupled from the parent event loop and therefore the assumption "it's nodejs it will def. only use one CPU" is not correct.


env:
USING_APP_CREDENTIALS: ${{ secrets.app_id != '' && secrets.private_key != '' }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/template_release_version.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ on:
jobs:
new_version:
name: Get new release version
runs-on: ubuntu-24.04
runs-on: ubuntu-slim

outputs:
new_version: ${{ steps.set_version.outputs.next_version }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/template_secret_scan.yml
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ jobs:
trufflehog:

name: trufflehog
runs-on: ubuntu-24.04
runs-on: ubuntu-slim

steps:
- name: Checkout code
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/template_stale.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
stale:

name: stale
runs-on: ubuntu-24.04
runs-on: ubuntu-slim

steps:
- name: Stale old PRs
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/template_techdocs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ on:
jobs:
techdocs:
name: TechDocs
runs-on: ubuntu-24.04
runs-on: ubuntu-slim

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/template_techdocs_monorepo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
jobs:
techdocs:
name: TechDocs
runs-on: ubuntu-24.04
runs-on: ubuntu-slim

steps:
- name: Checkout code
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/template_terraform_format.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ on:
jobs:
format:
name: Format
runs-on: ubuntu-24.04
runs-on: ubuntu-slim
steps:
- name: Get App Token
uses: actions/create-github-app-token@v2.2.0
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/template_yaml.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ on:
jobs:
yamllint:
name: yamllint
runs-on: ubuntu-24.04
runs-on: ubuntu-slim

steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/versions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:

jobs:
update_readme:
runs-on: ubuntu-24.04
runs-on: ubuntu-slim
steps:
- name: Checkout the source code
uses: actions/checkout@v6
Expand Down