-
Notifications
You must be signed in to change notification settings - Fork 0
Switch all workflows to ubuntu-slim except GitOps #378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,7 +39,7 @@ on: | |
| jobs: | ||
| update_release_draft: | ||
| name: update release draft | ||
| runs-on: ubuntu-24.04 | ||
| runs-on: ubuntu-slim | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wouldn't use the slim thing here since this is on the release production path and therefore time to market will be decreased when change this.
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To my intuition this shouldn't become slower. The release-drafter action is a nodejs action which means it runs single-threaded anyway. So the switch to 1vCPU shouldn't matter 🤔 ? If ubuntu-slim runs in a container instead of a VM we might even experience faster cold starts 🤔 This line of thinking applies to all actions you commented on.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This sounds reasonable. 👍 |
||
|
|
||
| env: | ||
| USING_APP_CREDENTIALS: ${{ secrets.app_id != '' && secrets.private_key != '' }} | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,7 +32,7 @@ jobs: | |
| stale: | ||
|
|
||
| name: stale | ||
| runs-on: ubuntu-24.04 | ||
| runs-on: ubuntu-slim | ||
|
|
||
| steps: | ||
| - name: Stale old PRs | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.