Repository navigation
qt: require Network for walletless Ord GUI build - #1
Closed
Joopooranski wants to merge 1 commit into
Closed
Joopooranski wants to merge 1 commit into
Joopooranski wants to merge 1 commit into
Conversation
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to bitcoindogmode#12. The Ord GUI code links
Qt6::Networkeven when wallet support is disabled, but the root CMake configuration currently discovers that Qt component only withENABLE_WALLET=ON.Reproduce on the Ord branch with
cmake -S . -B build -DBUILD_GUI=ON -DENABLE_WALLET=OFF -DENABLE_IPC=OFF: generation fails because targetQt6::Networkwas not found. Include Network in the GUI component list unconditionally and remove the wallet-only append.Validation on Ubuntu 24.04 with Qt 6.4.2: the same CMake configuration and generation succeed after this change.
bitcoin.cpp.oandordmanager.cpp.ocompile successfully in the wallet-disabled build. The fullbitcoin-qtlink was not completed locally.