You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
dxcvvxd
changed the title
added new desktop entry keywords to scripts/package-linux.sh
added new desktop entry keywords to scripts/install-linux.sh
Sep 17, 2026
Thanks for spotting this and for the prior work in #98. The idea is right: install-linux.sh was missing the same GenericName and Keywords fields that you added to package-linux.sh in #98.
The diff here has two changes that I could not take as-is: Exec="$launcher" was replaced with Exec=Optimum, and Path=$INSTALL_DIR was removed. In the installer case $launcher expands to the full absolute path of optimum-launch.sh inside the install directory, so the desktop entry needs that full path. Exec=Optimum only works in the AppImage case in package-linux.sh where Optimum is the AppRun entry point at the AppImage virtual root. Using a bare name in the installer entry would break the menu shortcut on any machine where the install directory is not on PATH.
I took the two fields you proposed (GenericName and Keywords) and applied them to install-linux.sh and install-linux-legacy.sh without touching Exec or Path, and merged that in PR #109. Your contribution got the right fields into the right place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
forgot to do in the previous pr