Skip to content

added new desktop entry keywords to scripts/install-linux.sh - #106

Closed
dxcvvxd wants to merge 1 commit into
StratumServer:mainfrom
dxcvvxd:main
Closed

dxcvvxd wants to merge 1 commit into
StratumServer:mainfrom
dxcvvxd:main

Conversation

@dxcvvxd

@dxcvvxd dxcvvxd commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

forgot to do in the previous pr

@dxcvvxd dxcvvxd changed the title added new desktop entry keywords to scripts/package-linux.sh added new desktop entry keywords to scripts/install-linux.sh Sep 17, 2026
@Zaldaryon

Copy link
Copy Markdown
Collaborator

Thanks for spotting this and for the prior work in #98. The idea is right: install-linux.sh was missing the same GenericName and Keywords fields that you added to package-linux.sh in #98.

The diff here has two changes that I could not take as-is: Exec="$launcher" was replaced with Exec=Optimum, and Path=$INSTALL_DIR was removed. In the installer case $launcher expands to the full absolute path of optimum-launch.sh inside the install directory, so the desktop entry needs that full path. Exec=Optimum only works in the AppImage case in package-linux.sh where Optimum is the AppRun entry point at the AppImage virtual root. Using a bare name in the installer entry would break the menu shortcut on any machine where the install directory is not on PATH.

I took the two fields you proposed (GenericName and Keywords) and applied them to install-linux.sh and install-linux-legacy.sh without touching Exec or Path, and merged that in PR #109. Your contribution got the right fields into the right place.

@Zaldaryon Zaldaryon closed this Sep 17, 2026
@dxcvvxd

dxcvvxd commented Sep 17, 2026

Copy link
Copy Markdown
Contributor Author

yeah thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants