feat: add GenericName and Keywords to installer desktop entries - #109
Merged
Merged
Conversation
PR #98 added GenericName and Keywords to the AppImage desktop entry in package-linux.sh. The equivalent templates in install-linux.sh and install-linux-legacy.sh were not updated at that time. Add the same two fields to both installer scripts. Exec and Path are left unchanged: the installer desktop entries use a full path to optimum-launch.sh, which differs from the AppImage case in package-linux.sh where the executable is on PATH inside the AppImage root.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #98 added GenericName and Keywords to the AppImage desktop entry in scripts/package-linux.sh. The same fields were not added to the equivalent templates in scripts/install-linux.sh and scripts/install-linux-legacy.sh at that time.\n\nThis adds both fields to both installer scripts, mirroring what PR #98 did for the packaged case. Exec and Path are left unchanged: the installer scripts use a full absolute path to optimum-launch.sh (not a bare name), which is different from the AppImage case where the executable is the AppRun entry point on the AppImage virtual PATH.\n\nAddresses the intent of PR #106 from dxcvvxd.