Lock user stats/grades for update#126
Merged
richardscull merged 9 commits intoJun 14, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we are going to add lock for user stats and grades during score processing. As both entries are doing increments/decrements, we need to make sure the entities being updates are up-to-date.
I originally wanted to use atomic updates, but in MySQL database there is no good way to update entity and fetch new results as a single query. Another problem is that you can't ask EF Core to handle the atomic update itself, so you need to provide the delta values to the new method, which looks very sloppy.
As per my assumption, any score processing update will be blocked by the beatmap retrieval. Si using lock here wouldn't hurt the performance in general.
Another changes: