Skip to content

feat: support auth-aware generation previews - #33

Merged
mikeylong merged 1 commit into
mainfrom
codex/interfacectl-generation-benchmark-loop
Mar 13, 2026
Merged

mikeylong merged 1 commit into
mainfrom
codex/interfacectl-generation-benchmark-loop

Conversation

@mikeylong

Copy link
Copy Markdown
Collaborator

Summary

  • add support to
  • allow authenticated preview capture to reuse saved Playwright browser state
  • keep generation preview capture CLI-only and aligned with session/benchmark flows

Verification

  • pnpm --filter @surfaces/interfacectl-cli run build
  • pnpm --filter @surfaces/interfacectl-cli exec node --test test/generation-session.test.mjs test/generation-benchmark.test.mjs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 55a89920ed

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +1839 to +1842
const context = await browser.newContext({
viewport,
...(storageStatePath ? { storageState: storageStatePath } : {}),
});

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Treat invalid storage-state files as input errors

If --storage-state points to a file that exists but contains malformed or incompatible Playwright state, browser.newContext throws at this call site before execution reaches the inner try/catch that converts failures into SessionInputError. The outer handler then reports generation-session.internal and returns exit code 1, which misclassifies a user-fixable argument problem and breaks callers that rely on exit code 10 for invalid inputs.

Useful? React with 👍 / 👎.

@mikeylong
mikeylong merged commit 2d20658 into main Mar 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant