feat: support auth-aware generation previews - #33
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 55a89920ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const context = await browser.newContext({ | ||
| viewport, | ||
| ...(storageStatePath ? { storageState: storageStatePath } : {}), | ||
| }); |
There was a problem hiding this comment.
Treat invalid storage-state files as input errors
If --storage-state points to a file that exists but contains malformed or incompatible Playwright state, browser.newContext throws at this call site before execution reaches the inner try/catch that converts failures into SessionInputError. The outer handler then reports generation-session.internal and returns exit code 1, which misclassifies a user-fixable argument problem and breaks callers that rely on exit code 10 for invalid inputs.
Useful? React with 👍 / 👎.
Summary
Verification