Skip to content

feat: support auth-aware generation previews #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikeylong merged 1 commit into from
Mar 13, 2026
Merged

feat: support auth-aware generation previews #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/interfacectl-cli/dist/commands/generation-session.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ export interface CaptureGenerationPreviewCommandOptions {
attemptNumber?: string | number;
url?: string;
waitFor?: string;
storageStatePath?: string;
}
export interface ReviewGenerationAttemptCommandOptions {
sessionDir?: string;
Expand Down
2 changes: 1 addition & 1 deletion packages/interfacectl-cli/dist/commands/generation-session.d.ts.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 8 additions & 1 deletion packages/interfacectl-cli/dist/commands/generation-session.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1207,13 +1207,20 @@ export async function runCaptureGenerationPreviewCommand(options) {
throw new SessionInputError(`Preview URL must use http or https: ${options.url}.`);
}
const viewport = { width: 1440, height: 1024 };
const storageStatePath = asString(options.storageStatePath);
if (storageStatePath && !fs.existsSync(storageStatePath)) {
throw new SessionInputError(`Storage state file not found: ${storageStatePath}.`);
}
const browser = await chromium.launch({
headless: process.env.INTERFACECTL_PLAYWRIGHT_HEADLESS !== "0" &&
process.env.INTERFACECTL_PLAYWRIGHT_HEADLESS !== "false",
}).catch((error) => {
throw toBrowserLaunchError(error);
});
const context = await browser.newContext({ viewport });
const context = await browser.newContext({
viewport,
...(storageStatePath ? { storageState: storageStatePath } : {}),
});
const page = await context.newPage();
try {
await page.goto(parsedUrl.toString(), { waitUntil: "load", timeout: 15_000 });
Expand Down
2 changes: 2 additions & 0 deletions packages/interfacectl-cli/dist/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,12 +248,14 @@ program
.requiredOption("--attempt <number>", "Attempt number to capture")
.requiredOption("--url <url>", "Absolute preview URL to capture")
.option("--wait-for <value>", "Optional text or selector to wait for before capturing")
.option("--storage-state <path>", "Optional Playwright storage state JSON file for authenticated previews")
.action(async (options) => {
process.exitCode = await runCaptureGenerationPreviewCommand({
sessionDir: options.sessionDir,
attemptNumber: options.attempt,
url: options.url,
waitFor: options.waitFor,
storageStatePath: options.storageState,
});
});
program
Expand Down
10 changes: 9 additions & 1 deletion packages/interfacectl-cli/src/commands/generation-session.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ export interface CaptureGenerationPreviewCommandOptions {
attemptNumber?: string | number;
url?: string;
waitFor?: string;
storageStatePath?: string;
}

export interface ReviewGenerationAttemptCommandOptions {
Expand Down Expand Up @@ -1824,14 +1825,21 @@ export async function runCaptureGenerationPreviewCommand(
}

const viewport = { width: 1440, height: 1024 };
const storageStatePath = asString(options.storageStatePath);
if (storageStatePath && !fs.existsSync(storageStatePath)) {
throw new SessionInputError(`Storage state file not found: ${storageStatePath}.`);
}
const browser = await chromium.launch({
headless:
process.env.INTERFACECTL_PLAYWRIGHT_HEADLESS !== "0" &&
process.env.INTERFACECTL_PLAYWRIGHT_HEADLESS !== "false",
}).catch((error) => {
throw toBrowserLaunchError(error);
});
const context = await browser.newContext({ viewport });
const context = await browser.newContext({
viewport,
...(storageStatePath ? { storageState: storageStatePath } : {}),
});
Comment on lines +1839 to +1842

@chatgpt-codex-connector chatgpt-codex-connector Bot Mar 13, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Treat invalid storage-state files as input errors

If --storage-state points to a file that exists but contains malformed or incompatible Playwright state, browser.newContext throws at this call site before execution reaches the inner try/catch that converts failures into SessionInputError. The outer handler then reports generation-session.internal and returns exit code 1, which misclassifies a user-fixable argument problem and breaks callers that rely on exit code 10 for invalid inputs.

Useful? React with 👍 / 👎.

const page = await context.newPage();

try {
Expand Down
2 changes: 2 additions & 0 deletions packages/interfacectl-cli/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,12 +357,14 @@ program
.requiredOption("--attempt <number>", "Attempt number to capture")
.requiredOption("--url <url>", "Absolute preview URL to capture")
.option("--wait-for <value>", "Optional text or selector to wait for before capturing")
.option("--storage-state <path>", "Optional Playwright storage state JSON file for authenticated previews")
.action(async (options) => {
process.exitCode = await runCaptureGenerationPreviewCommand({
sessionDir: options.sessionDir,
attemptNumber: options.attempt,
url: options.url,
waitFor: options.waitFor,
storageStatePath: options.storageState,
});
});

Expand Down
Loading