[TSVRN9]

Closes #67

Summary

• shared/src/ranking.ts: distinctLoggedDishes (extracts the distinct umass-menu dishes a user has logged, in first-seen order) and pickPostLogComparisonPair (the "when to offer, which pair" logic) -- reuses applyComparison's dish identity (dishName+hallTid) and RankedDish.comparisonCount, the same signal /rank's own picker prefers under-compared dishes with. Red-first unit coverage in shared/src/ranking.test.ts (9 new tests -- see the correction note below).
• web/src/routes/halls/[slug]/+page.svelte: after logging a dish, offers a dismissible, non-modal one-tap comparison prompt against the least-compared previously-logged dish, if a valid pair exists. Choosing a winner writes both Elo tracks (RankedDish + RankedFood) via IndexedDbRankingStorage, same as /rank's own choose().
• web/src/routes/+page.svelte: "Your Top Dishes" module -- top 3 device-local ranked dishes (rankDishes(...).slice(0, 3)), empty state (gated on both directions to avoid an SSR/pre-hydration loading flash) linking to /rank via "Start ranking" (not "Compare dishes" -- avoids colliding with the existing quick-link's accessible name).
• web/e2e/rank-surfaces.spec.ts: 9 e2e tests covering both surfaces, including a trial-click actionability check proving the comparison prompt never intercepts the header nav or a Log button.

Review fix (blocking): prompt placement ceiling

The comparison prompt originally rendered in normal document flow, directly under the date nav (see "Known simplification" below for why plain flow was chosen over the alternatives tried at the time). On a realistic-length menu that ceiling is real, not theoretical: logging dish #35 on a ~40-dish menu left the prompt ~4800px above the viewport (toBeInViewport() ratio 0) -- offered only in the DOM, not to the user, which breaks #67 AC2 ("offer a prompt"). The original 2-dish e2e fixture couldn't see this; all 8 specs passed vacuously regardless of placement.

Fixed by moving the prompt to a bottom-anchored, viewport-fixed position, stacked with the existing bottom-fixed status toast via a flex-col-reverse wrapper so whichever of them is showing lands at the very bottom and the other stacks above it -- they can both be visible at once right after a second log, and this ordering keeps them from ever overlapping regardless of either one's height (no hardcoded pixel gap). The wrapper is pointer-events-none so it never blocks clicks on the page underneath; each child re-enables pointer-events-auto for its own bounds.

Red-first: rank-surfaces.spec.ts gained a ~40-dish long-menu fixture and two new specs --

1. logging a dish far down the list asserts the prompt toBeInViewport() (confirmed red against the pre-fix document-flow version: viewport ratio 0);
2. a { trial: true } actionability check run at the actually-scrolled position (not scroll 0 -- a real click auto-scrolls its target into view first, which is exactly how the original fixed-position attempt passed every spec in this file while intercepting the header nav, caught only by rank.spec.ts:80, a different file), plus a geometry assertion that the prompt's bottom edge never extends past the toast's top edge. That geometry assertion was itself mutation-verified: temporarily forcing the prompt back to fixed bottom-5 left-1/2 (overlapping the toast) reproduced a red failure (Expected: <= 665, Received: 700); reverted immediately after confirming.

rank.spec.ts:47/:80 (the pre-existing interception canaries) and the full suite were re-run after the change -- all green (see Verification below).

The now-inaccurate ponytail: comment describing plain document flow was removed; the new bottom-anchored comment documents a smaller, real residual ceiling instead (narrow-viewport overlap with the last dish row's Log button -- untested, since this repo's Playwright config only runs a Desktop Chrome project).

Data residency

Both surfaces are strictly device-local (IndexedDB via IndexedDbRankingStorage) -- zero server calls, no auth gate, per CLAUDE.md's data residency table. Previously "verified" by a dedicated page.route("**/api/**") guard test in this file; that test has been deleted, not rewritten -- it's the same pattern home-dashboard.spec.ts's own comment documents as retired repo-wide (a fetch(..., { mode: "no-cors" }) call sails past a route-glob guard undetected). home-dashboard.spec.ts's page.on("request") guard already covers /, which both surfaces render on/link from, so this is deletion of a redundant, weaker check, not a coverage loss.

Declared, deliberate gap: chooseCompare in halls/[slug]/+page.svelte does not call syncDiningHallRanks, unlike /rank's own choose(). Per ADR 0001's Consequences clause, new code reacting to a Pairwise Comparison must touch both Elo tracks or justify touching only one -- this does update both tracks, but is a third reactor to the comparison event and doesn't sync. Adding that sync call would put a Supabase network call on the logging surface, beyond what #67 asks for (and its own constraint is zero server calls here). A signed-in user who only ever compares via this prompt won't sync their favorite dining halls until they also visit /rank. Flagging as a follow-up rather than silently fixing or silently omitting.

Minor cleanup taken in the same pass

loggedDishKey in shared/src/ranking.ts now delegates to the module-private dishKey instead of re-literalizing the ${dishName}::${hallTid} format a third time in the same file.

Correction: the "24 new tests" claim in this PR and in #67 was wrong

The original red-first log (posted on #67) reported import-level red -- SyntaxError: does not provide an export named 'distinctLoggedDishes' -- which fails the whole test file at load time, not per-assertion. Counting "65 total after, 41 before the failing import" as "24 new" double-counted the file's 16 pre-existing tests (which also couldn't run while the import failed). The real number of new tests added for distinctLoggedDishes/pickPostLogComparisonPair is 9 (verified directly: grep -c '^test(' shared/src/ranking.test.ts before this PR's other tests were touched shows 25 total in that file, 16 pre-existing + 9 new). Posting this correction on #67 as well.

Verification

• pnpm --filter @udine/shared test -- 65 passed
• CI=1 PORT=4316 npx playwright test (full suite) -- 66 passed (up from the 59 reported at the original PR -- the delta is mostly origin/main's web: social activity feed (pings + sightings) #75 social-feed merge, not this branch; this branch's own net e2e change is 8 → 9 in rank-surfaces.spec.ts, +2 new specs -1 deleted residency guard)
• pnpm --filter web check -- 0 errors, 0 warnings
• pnpm --filter web build -- succeeded
• cd mobile && npx tsc --noEmit -- clean (shared/ changed)
• pnpm --filter mobile test -- 35 passed (shared/ changed)

Full red/green log and per-criterion evidence posted on #67; this review-fix's red/green evidence is in this PR body above and mirrored in a new #67 comment.

Test plan

• Shared pair-selection logic unit-tested red-first (import-level red: does not provide an export named 'distinctLoggedDishes')
• Post-log prompt appears/dismisses correctly (e2e, red evidence pasted on web: rank-informed surfaces (post-log compare prompt, top dishes) #67); logging flow specs unweakened (halls-menu.spec.ts unmodified, still green)
• Post-log prompt is actually reachable on a realistic-length menu, not just offered in the DOM (blocking review finding -- see "Review fix" above; red-first, mutation-verified)
• Top-dishes module on home with empty state
• Full suite green, check clean, shared tests green (local CI lanes -- remote CI is disabled per CLAUDE.md)

[TSVRN9]

Addressed the blocking review finding: the post-log comparison prompt rendered in document flow directly under the date nav, so on a realistic-length menu it sat far above the viewport after logging a dish deep in the list (probe confirmed: toBeInViewport() ratio 0, top -4803px, logging dish #35 on a ~40-dish fixture). Offered only in the DOM, not to the user -- breaks #67 AC2. The original 2-dish e2e fixture couldn't catch this; all 8 specs passed vacuously regardless of placement.

Fix (web/src/routes/halls/[slug]/+page.svelte): bottom-anchored, viewport-fixed placement, stacked with the existing bottom-fixed status toast via a flex-col-reverse wrapper -- whichever of the two is showing lands at the very bottom, the other stacks above it, and they can never overlap regardless of either one's height (no hardcoded pixel gap). Wrapper is pointer-events-none; each child re-enables pointer-events-auto for its own bounds, so the stack never blocks clicks on the page underneath.

Red-first (web/e2e/rank-surfaces.spec.ts): added a ~40-dish long-menu fixture (synthetic dish names/nutrition run through the real parseCategoryItems) and two specs:

1. Logging a dish far down the list asserts toBeInViewport() -- ran this against the pre-fix code first and got the exact red the reviewer's probe describes (viewport ratio 0).
2. A { trial: true } actionability check run at the actually-scrolled position (not scroll 0 -- a real .click() auto-scrolls its target into view, which is exactly how the earlier fixed top-* attempt passed every spec in this file while intercepting the header nav, caught only by rank.spec.ts:80, a different file), plus a geometry assertion that the prompt's bottom edge never extends past the toast's top edge. Mutation-verified that geometry assertion: temporarily forced the prompt back to fixed bottom-5 left-1/2 (overlapping the toast) and got a real failure (Expected: <= 665, Received: 700); reverted immediately after confirming red.

rank.spec.ts:47/:80 (the pre-existing interception canaries) and the full suite were re-run after the change -- all green.

Also from the same review pass:

• Deleted the page.route("**/api/**") residency-guard test in rank-surfaces.spec.ts (not rewritten) -- retired pattern, per home-dashboard.spec.ts's own comment (a no-cors cross-origin fetch sails past a route-glob guard); that file's page.on("request") guard already covers /.
• Corrected the "24 new tests" claim in this PR body and on web: rank-informed surfaces (post-log compare prompt, top dishes) #67 -- the real number is 9; posting a separate correction comment on web: rank-informed surfaces (post-log compare prompt, top dishes) #67.
• shared/src/ranking.ts: loggedDishKey now delegates to the module-private dishKey instead of re-literalizing the ${dishName}::${hallTid} format a third time in the file. Shared tests re-run (65 passed), mobile tsc --noEmit clean, pnpm --filter mobile test 35 passed.
• Updated/removed the now-inaccurate ponytail: comment describing plain document flow; the new comment names the smaller residual ceiling (narrow-viewport overlap with the last dish row's Log button -- untested, this repo's Playwright config only runs a Desktop Chrome project).

Merged origin/main in first (#75 social feed, #79 README) -- no conflicts.

Verification (all local, per CLAUDE.md's "CI is local-only"):

• pnpm --filter @udine/shared test -- 65 passed
• CI=1 PORT=4316 npx playwright test (full suite) -- 66 passed
• pnpm --filter web check -- 0 errors, 0 warnings
• pnpm --filter web build -- succeeded
• cd mobile && npx tsc --noEmit -- clean
• pnpm --filter mobile test -- 35 passed

Not merging -- pushed to feat/rank-surfaces for review.