fix: correct .gitignore and some comments#53
Open
gukj-spel wants to merge 2 commits intoTencent:coo-consistency-checkfrom
Open
fix: correct .gitignore and some comments#53gukj-spel wants to merge 2 commits intoTencent:coo-consistency-checkfrom
gukj-spel wants to merge 2 commits intoTencent:coo-consistency-checkfrom
Conversation
|
can you edit your pr title to "fix: correct .gitignore and some comments"? |
Author
sure |
gukj-spel
changed the title
hldgs
suggested changes
Jul 24, 2024
| @@ -1,5 +1,5 @@ | |||
| build/* | |||
| .vscode/* | |||
| *build*/ | |||
There was a problem hiding this comment.
why "*build*/" ? I think "build/" is sufficient.
| * @param db_type The type of the database (e.g., "oracle", "mysql"). | ||
| * @param test_process_file The file to log test process. | ||
| * @return True if the query execution is successful, false otherwise. | ||
| * Executes multiple SQL transactions in a multi-threaded environment. |
There was a problem hiding this comment.
"Executes multiple SQL transactions", the rest is unnecessary in this line
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify the .gitgnore and correct a function comment: