-
Notifications
You must be signed in to change notification settings - Fork 66
fix: correct .gitignore and some comments #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gukj-spel
wants to merge
2
commits into
Tencent:coo-consistency-check
Choose a base branch
from
gukj-spel:some_little_bug
base: coo-consistency-check
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| build/* | ||
| .vscode/* | ||
| *build*/ | ||
| .vscode/ | ||
| *.cfg | ||
| __* | ||
| *.o | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -45,15 +45,16 @@ bool try_lock_wait(float wait_second, float wait_nanosecond, int txn_id) | |
| } | ||
|
|
||
| /** | ||
| * Executes a SQL query and returns the result. | ||
| * | ||
| * @param sql The SQL query to execute. | ||
| * @param session_id The session ID for tracking. | ||
| * @param sql_id The SQL query ID for tracking. | ||
| * @param test_result_set The test result set to store results. | ||
| * @param db_type The type of the database (e.g., "oracle", "mysql"). | ||
| * @param test_process_file The file to log test process. | ||
| * @return True if the query execution is successful, false otherwise. | ||
| * Executes multiple SQL transactions in a multi-threaded environment. | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "Executes multiple SQL transactions", the rest is unnecessary in this line |
||
| * | ||
| * @param txn_sql_list The list of transaction SQL to execute. | ||
| * @param test_sequence Represents the test sequence object. | ||
| * @param test_result_set Represents the expected test result set object. | ||
| * @param db_connector The object used for database interactions. | ||
| * @param test_process_file The file for logging or recording the test process. | ||
| * @param cur_result_set A map to store the current result set. | ||
| * @param sleeptime The sleep time between transaction executions. Note: Different threads may have different sleep times to stagger their execution. | ||
| * @return True if the transactions are executed successfully, false otherwise. | ||
| */ | ||
| bool MultiThreadExecution(std::vector<TxnSql>& txn_sql_list, TestSequence& test_sequence, TestResultSet& test_result_set, | ||
| DBConnector db_connector, std::string test_process_file, std::unordered_map<int, std::vector<std::string>>& cur_result_set, int sleeptime){ | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why "*build*/" ? I think "build/" is sufficient.