Skip to content

test(session): pass a session ref to CodexAdapter.readSession - #1152

Merged
jeff-r2026 merged 1 commit into
Tencent:mainfrom
SaulMoro:test/codex-read-session-ref
Oct 15, 2026
Merged

jeff-r2026 merged 1 commit into
Tencent:mainfrom
SaulMoro:test/codex-read-session-ref

Conversation

@SaulMoro

Copy link
Copy Markdown
Collaborator

Summary

main fails tsc since #1146 merged:

src/__tests__/session-cmd.test.ts(1579,58): error TS2345: Argument of type 'string' is not assignable to parameter of type 'SessionReadRef'.

#1146 added a test that calls new CodexAdapter().readSession(SID). #1135, merged just before it, changed readSession to take a SessionReadRef. Each PR passed CI on its own base. This passes { sessionId: SID }, as the other adapter tests in the file already do.

-    const session = await new CodexAdapter().readSession(SID);
+    const session = await new CodexAdapter().readSession({ sessionId: SID });

Evidence

  • On main at 7ca23dc: npx tsc --noEmit fails with the error above.
  • On this branch: npx tsc --noEmit passes, and npx vitest run src/__tests__/session-cmd.test.ts -t 'freeform tool calls' passes (1 test).
  • Test-only change, so no CLI run.

Merge Danger

Door: two-way. One line in one test. Until this merges, the CI type check fails for every PR tested against main.

@github-actions

Copy link
Copy Markdown

No findings in the requested diff.

The change is limited to one test call, passing { sessionId: SID } instead of a string. The PR description documents a passing type check and focused unit test—sufficient for this test-only change; no real-CLI record is required.

I did not run, build, or install anything from the PR.

@jeff-r2026
jeff-r2026 merged commit 564826f into Tencent:main Oct 15, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants