Repository navigation
test(session): pass a session ref to CodexAdapter.readSession - #1152
Merged
Merged
Conversation
|
No findings in the requested diff. The change is limited to one test call, passing I did not run, build, or install anything from the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainfailstscsince #1146 merged:#1146 added a test that calls
new CodexAdapter().readSession(SID). #1135, merged just before it, changedreadSessionto take aSessionReadRef. Each PR passed CI on its own base. This passes{ sessionId: SID }, as the other adapter tests in the file already do.Evidence
mainat 7ca23dc:npx tsc --noEmitfails with the error above.npx tsc --noEmitpasses, andnpx vitest run src/__tests__/session-cmd.test.ts -t 'freeform tool calls'passes (1 test).Merge Danger
Door: two-way. One line in one test. Until this merges, the CI type check fails for every PR tested against
main.