Skip to content

test(session): pass a session ref to CodexAdapter.readSession #1152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeff-r2026 merged 1 commit into from
Oct 15, 2026
Merged

test(session): pass a session ref to CodexAdapter.readSession #1152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/__tests__/session-cmd.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1576,7 +1576,7 @@
lines.map((l) => JSON.stringify({ timestamp: '2026-10-01T10:00:00.000Z', ...l })).join('\n') + '\n',
);

const session = await new CodexAdapter().readSession(SID);
const session = await new CodexAdapter().readSession({ sessionId: SID });

Check failure on line 1579 in src/__tests__/session-cmd.test.ts

View workflow job for this annotation

GitHub Actions / Codex PR Review 

Argument of type 'string' is not assignable to parameter of type 'SessionReadRef'.
const call = session.messages.flatMap((m) => m.content).find((b) => b.type === 'tool_call');
expect(call).toMatchObject({ type: 'tool_call', toolName: 'edit_file', callId: 'call_1', arguments: { input: patch } });
});
Expand Down
Loading