Update SITREP browser fixture for core graph - #66
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e55e9f9e75
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| await expect(page.getByRole('navigation', { name: 'Repository situation index' }).locator('a')).toHaveCount(11); | ||
| await expect(page.locator('.sitrep-card')).toHaveCount(11); |
There was a problem hiding this comment.
When refresh:sitrep enters its supported fallback path—for example, after a transient GitHub/control-plane failure or with OFFLINE=1—a clean checkout copies the committed last-known-good snapshot, which still contains five projects, so the template renders five navigation links and cards. The Pages and pull-request workflows run this browser suite after the build without rejecting SITREP fallback data, so these exact 11 assertions turn a recoverable refresh failure into a failed release check; derive the expectation from the rendered snapshot or ensure fallback data always projects all 11 members.
Useful? React with 👍 / 👎.
1 participant
Repairs the two Playwright assertions that still expected the old five-project SITREP. The production build, deterministic portfolio projection, 11-project/0-missing-report generation, unit tests, generated-site tests, links, and performance gates already passed; this updates only the browser fixture to the new explicit 11-member core graph.