Repository navigation
Conversation
…ndividually
nangate45/mempool_group's VERILOG_FILES names the files under
src/mempool_group/rtl one by one. bazel-orfs's config.mk parser turns
each into a per-file label, and a bare filegroup over a glob makes those
files private to this package, so the design fails analysis under bazel
with a visibility error on every one of them.
files("include", extra_srcs = ...) is the same filegroup -- the same
glob plus the same five sibling-package headers -- and also exports each
source as its own label. No change to what the include group contains.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Signed-off-by: Øyvind Harboe <oyvind.harboe@zylin.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the BUILD file in flow/designs/src/mempool_group/rtl to replace the filegroup target with a custom files macro loaded from //flow/designs:design.bzl. This change ensures that globbed sources are exported as individual labels, which is required by the config.mk parser in bazel-orfs. There are no review comments, so I have no feedback to provide.
Collaborator
Author
|
Closing: opened without the maintainer's go-ahead. bazel-orfs carries this as a patch for now; an upstream PR will follow when it has settled and the timing is right. |
Member
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Advisory — results are log-only and do not affect build status. The authoritative QoR gate remains the local rules-file check. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nangate45/mempool_group'sVERILOG_FILESnames the files undersrc/mempool_group/rtlone by one. bazel-orfs's config.mk parser turns each into a per-file label, and a barefilegroupover a glob makes those files private to the package, so the design fails analysis under bazel with a visibility error on every one of them:files("include", extra_srcs = ...)is the same filegroup, the same glob plus the same five sibling-package headers, and also exports each source as its own label. No change to what theincludegroup contains. Every othersrc/package already usesfiles().🤖 Generated with Claude Code