Skip to content

designs: mempool_group/rtl BUILD uses files() so its sources export individually #4517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
oharboe wants to merge 1 commit into from
Closed

designs: mempool_group/rtl BUILD uses files() so its sources export individually #4517

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions flow/designs/src/mempool_group/rtl/BUILD
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,18 @@
filegroup(
name = "include",
srcs = glob(["*.v", "*.sv", "*.svh"], allow_empty = True) + [
load("//flow/designs:design.bzl", "files")

# files() rather than a bare filegroup: the globbed sources are then also
# exported as individual labels, which the config.mk parser in bazel-orfs
# needs -- nangate45/mempool_group's VERILOG_FILES names files in this
# directory one by one, and a bare filegroup makes them private to it.
# The extra sources are the headers from sibling packages that the
# include group has always carried.
files(
"include",
extra_srcs = [
"//flow/designs/src/mempool_group/rtl/axi:assign.svh",
"//flow/designs/src/mempool_group/rtl/axi:typedef.svh",
"//flow/designs/src/mempool_group/rtl/common_cells:assertions.svh",
"//flow/designs/src/mempool_group/rtl/common_cells:registers.svh",
"//flow/designs/src/mempool_group/rtl/mempool:mempool.svh",
],
visibility = ["//visibility:public"],
)