Repository navigation
fixed ORFS flow variables for AutoTuner - #4520
Merged
vvbandeira merged 1 commit intoSep 9, 2026
Merged
vvbandeira merged 1 commit into
vvbandeira merged 1 commit into
Conversation
Signed-off-by: Cho Moon <cmoon@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the handling of the environment variables SWAP_ARITH_OPERATORS, SYNTH_OPT_HIER, and SYNTH_WRAPPED_OPERATORS across various Tcl scripts, changing the check from existence to an explicit equality check of 1. It also defines their default values as 0 in the documentation, JSON, and YAML configuration files. There are no review comments, and I have no feedback to provide.
Member
Author
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Advisory — results are log-only and do not affect build status. The authoritative QoR gate remains the local rules-file check. Commit 62 design(s) checked — 0 with regression(s), 0 without a comparable baseline.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the issue reported by @jeffng-or involving SYNTH_WRAPPED_OPERATORS, SWAP_ARITH_OPERATORS and SYNTH_OPT_HIER variables in AutoTuner. A simple [0, 1] in the config file doesn't disable or enable the feature because the variable is referenced by env_var_exists_and_non_empty, not env_var_equals. This fixes the issue https://github.com/The-OpenROAD-Project-private/OpenROAD/issues/3741.