Added failing unit test for most common case; switching while file not in cwd#40
Open
TamaMcGlinn wants to merge 1 commit intoThePrimeagen:masterfrom
Open
Added failing unit test for most common case; switching while file not in cwd#40TamaMcGlinn wants to merge 1 commit intoThePrimeagen:masterfrom
TamaMcGlinn wants to merge 1 commit intoThePrimeagen:masterfrom
Conversation
Collaborator
|
the test is failing early because the test repo does not contain a branch name featD, there is just master with A.txt, featB with A.txt and B.txt, and featC with A.txt and C.txt |
Owner
|
Is there any resolve on this? Is this a failing case, or a non case? |
Author
|
it fails, but not in the right way. How do I add the featD worktree? |
Collaborator
|
In the test folder |
86a8fe4 to
7abb179
Compare
Author
|
Thank you, now it fails on the correct assertion - that the file is indeed not opened after switching to a worktree which has that file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it is clear in this test that we would want to open file A.txt in the target dir, since we were editing A and A exists in the target. However, what actually happens is that '../featC/A.txt' is not found to be present in featD and hence it opens the root directory of the worktree. (I believe the test currently fails even slightly earlier, in switching, but this is probably due to not understanding the test framework; when I go through the steps manually in vim the switch of the cwd to featD does occur)