Fix aurora.skillissue.gg TXT record breaking the skillissue.gg deploy - #21
Merged
Merged
Conversation
The Railway verification TXT was stored as an object inside aurora/@.json, so deploy.js sent "[object Object]" and skrime rejected the zone. It also put a TXT next to a CNAME on the same name, which DNS does not allow. - Move it to aurora/_railway-verify.json (-> _railway-verify.aurora) - deploy.js: refuse non-string record values before POSTing - validate-pr.js: reject non-string values, allow _label record files Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Vzw95xoy6RWUeGkRfgbMST
Ownership check failedThis pull request changes a subdomain that belongs to someone else, so it is being closed automatically.
If you believe this is a mistake, please open an issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
skrime answered the skillissue.gg deploy with
Failed to update DNS records. The payload containedaurora TXT "[object Object]", becausedomains/skillissue.gg/aurora/@.jsonstored the Railway verification as an object ("TXT": {"_railway-verify": "..."}). That file also put a TXT next to a CNAME onaurora, which DNS does not allow.Changes:
domains/skillissue.gg/aurora/_railway-verify.json. It now deploys as_railway-verify.aurora TXT railway-verify=..., which is the name Railway checks, and@.jsonkeeps only the CNAME.deploy.js: throw on non-string record values before sending anything, so a broken file fails the run with a clear message and the live zone is left untouched.validate-pr.js: reject non-string or empty record values. Allow record files whose label starts with_(for example_railway-verify.json) so owners can add verification records the right way.Tested locally against a mock API: the payload now has 7 valid records, and the old file makes the script fail before the POST.
Note:
validatewill fail on this PR by design, because it touches files outsidedomains/.🤖 Generated with Claude Code
https://claude.ai/code/session_01Vzw95xoy6RWUeGkRfgbMST
Generated by Claude Code