Skip to content

fix(webui): let wheel gestures leave tool details at the scroll boundary - #1985

Merged
Open-Squilla merged 2 commits into
TokenRhythm:mainfrom
angri450:fix/tool-details-scroll-chain
Oct 26, 2026
Merged

Open-Squilla merged 2 commits into
TokenRhythm:mainfrom
angri450:fix/tool-details-scroll-chain

Conversation

@angri450

Copy link
Copy Markdown
Contributor

Scope

Presentation-only change in two inner scroll windows of the tool-detail card, plus a source guard.

Scope boundary: does not touch scroll ownership, live-edge follow logic, activity projection, or transcript data. Only the hand-off at the inner scroll boundary changes.

Non-goals: the live-edge pinning behaviour while an inner region still has range; that stays as it is.

Branch

Base branch: main

Target exception: N/A

Issue

Linked issue: Fixes #1889

Release Note

Release note: Wheel gestures over an expanded tool result now continue scrolling the conversation once the inner region reaches its top or bottom edge.

Tests

  • vitest for ActivityToolDetails (base, window, scrollChain) — 17 passed.
  • npm run typecheck:vue — clean.
  • npm run check:architecture — all guards passed.

Not run locally: Playwright e2e. The change is a computed-style value, and the existing e2e suite has no assertion on this boundary, so the new coverage is a source guard rather than a browser-level regression test. A browser check would confirm the chained gesture; the reported numbers in #1889 are the reference.

Regression tests: added

Maintainer Live Check

Maintainer live check: no

Surface: N/A

Maintainer-only note: contributors are not expected to provide secrets or run credentialed live checks.

Safety

No secrets, local-only artifacts, private prompts/transcripts, channel identifiers, or tests/_private/ contents are committed.

Third-Party Origin

Third-party origin: none

Details if non-none: N/A

Documentation Changes

  • Links point to existing repository files or stable external pages.
  • Code fences and Markdown tables render correctly on GitHub.
  • Examples avoid real secrets, local private paths, and private transcripts.

An expanded tool result keeps its own bounded scroll window inside the
transcript. Both that window and the code/diff viewport declared
`overscroll-behavior: contain`, so a wheel gesture that reached either inner
boundary was dropped instead of scrolling the conversation. During a live
turn the transcript also stayed pinned to the live edge until the pointer
moved onto ordinary text.

Use `overscroll-behavior: auto` on both inner windows so the remainder of the
gesture chains to the transcript. Scrolling inside a region that still has
range keeps moving only that region.

Adds a source guard that fails if either rule returns to `contain`.

Fixes TokenRhythm#1889
Copilot AI balanced review requested due to automatic review settings October 23, 2026 13:08

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@Open-Squilla
Open-Squilla added this pull request to the merge queue Oct 26, 2026
@Open-Squilla
Open-Squilla removed this pull request from the merge queue due to a manual request Oct 26, 2026
@github-actions

Copy link
Copy Markdown

Merge queue CI: cancelled — run 40274457423, attempt 1.
Tested queue candidate: 91356ac8faf6dc821ed2d90af4609b0b38e170d7. This result belongs to that combined tree, not necessarily the PR's current head.

The run summary lists reused suites and executed checks. A green PR check alone does not mean queue validation has passed.

@Open-Squilla
Open-Squilla added this pull request to the merge queue Oct 26, 2026
@github-actions

Copy link
Copy Markdown

Merge queue CI: success — run 40277991264, attempt 1.
Tested queue candidate: 94b6814e1137cd0999bbfc9b32d77f8b9775710e. This result belongs to that combined tree, not necessarily the PR's current head.

The run summary lists reused suites and executed checks. A green PR check alone does not mean queue validation has passed.

Merged via the queue into TokenRhythm:main with commit 94b6814 Oct 26, 2026
44 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Chat transcript does not scroll when wheel is over tool details during streaming

3 participants