Skip to content

fix(webui): let wheel gestures leave tool details at the scroll boundary #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Open-Squilla merged 2 commits into from
Oct 26, 2026
Merged

fix(webui): let wheel gestures leave tool details at the scroll boundary #1985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d8921b
fix(webui): let wheel gestures leave tool details at the scroll boundary
angri450 Oct 23, 2026
35441d9
Merge branch 'main' into fix/tool-details-scroll-chain
Open-Squilla Oct 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion opensquilla-webui/src/components/chat/ActivityCodeDetails.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,7 @@ const diffLines = computed(() => source.value.split('\n').map(text => ({
.activity-code-details__open { width: auto; padding: 0 0.375rem; font: inherit; opacity: 0; }
.activity-code-details:hover .activity-code-details__open,
.activity-code-details:focus-within .activity-code-details__open { opacity: 1; }
.activity-code-details__viewport { min-width: 0; width: 100%; max-height: min(20rem, 45vh); overflow: auto; overscroll-behavior: contain; scrollbar-width: thin; scrollbar-color: var(--border-strong) transparent; color: var(--text); }
.activity-code-details__viewport { min-width: 0; width: 100%; max-height: min(20rem, 45vh); overflow: auto; overscroll-behavior: auto; scrollbar-width: thin; scrollbar-color: var(--border-strong) transparent; color: var(--text); }
.activity-code-details pre,
.activity-code-details code { border: 0; border-radius: 0; background: transparent; box-shadow: none; font-family: var(--font-mono); font-size: 0.8125rem; font-weight: 400; line-height: 1.375rem; text-align: left; tab-size: 2; }
.activity-code-details pre { width: max-content; min-width: 100%; box-sizing: border-box; margin: 0; padding: 0; white-space: pre; }
Expand Down
23 changes: 23 additions & 0 deletions opensquilla-webui/src/components/chat/ActivityToolDetails.scrollChain.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
import { describe, expect, it } from 'vitest'

import codeDetailsSource from './ActivityCodeDetails.vue?raw'
import toolDetailsSource from './ActivityToolDetails.vue?raw'

function ruleFor(source: string, selector: string): string {
const start = source.indexOf(`${selector} {`)
expect(start, `${selector} rule`).toBeGreaterThanOrEqual(0)
return source.slice(start, source.indexOf('}', start) + 1)
}

describe('tool detail scroll windows', () => {
it('lets a wheel gesture at the inner boundary continue the transcript scroll', () => {
// `overscroll-behavior: contain` swallows the gesture at either inner
// boundary, so the transcript never moves while the pointer stays over the
// expanded details. Both the generic window and the code/diff viewport sit
// inside the chat column and must hand the remainder to it.
expect(ruleFor(toolDetailsSource, '.activity-tool-details__window'))
.toContain('overscroll-behavior: auto')
expect(ruleFor(codeDetailsSource, '.activity-code-details__viewport'))
.toContain('overscroll-behavior: auto')
})
})
2 changes: 1 addition & 1 deletion opensquilla-webui/src/components/chat/ActivityToolDetails.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -515,7 +515,7 @@ const detailActionLabel = computed(() => {
.activity-tool-details__log-status button { margin-inline-start: 0.5rem; padding: 0; border: 0; border-radius: var(--radius-sm); background: transparent; color: var(--text); font: inherit; text-decoration: underline; cursor: pointer; }
.activity-tool-details__log-status button:focus-visible { outline: none; box-shadow: var(--focus-ring); }
.activity-tool-details--bounded { position: relative; display: flex; flex-direction: column; max-width: 100%; max-height: min(20rem, 45vh); padding: 0; border: 1px solid var(--border); border-radius: var(--radius-md); background: var(--bg); overflow: hidden; }
.activity-tool-details__window { min-height: 0; padding: 0.875rem 2.75rem 0.875rem 0.875rem; overflow: auto; overscroll-behavior: contain; scrollbar-gutter: stable; }
.activity-tool-details__window { min-height: 0; padding: 0.875rem 2.75rem 0.875rem 0.875rem; overflow: auto; overscroll-behavior: auto; scrollbar-gutter: stable; }
.activity-tool-details__truncated { flex: 0 0 auto; margin: 0; padding: 0.375rem 0.875rem; color: var(--text-muted); font-size: 0.75rem; }
.activity-tool-details__window:focus-visible { outline: none; box-shadow: var(--focus-ring-inset); }
.activity-tool-details__section { margin: 0; padding: 0; border: 0; background: transparent; }
Expand Down
Loading