Implement public read-only MCP server with registry, schemas, CORS, docs, and tests#36
Closed
Trailgenic wants to merge 2 commits into
Closed
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Owner
Author
|
closing. superseded by PR 41 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
lib/ella-mcp-server.ts,lib/ella-mcp-schemas.ts, andlib/ella-registry.tsthat register tools and resources via the@modelcontextprotocol/sdkand expose envelope/provenance-aware outputs.app/mcp/route.tsto delegate POST handling tohandleEllaMcpPost, implement origin-aware CORS, requireAcceptnegotiation (application/json, text/event-stream) andContent-Type: application/json, and implement proper OPTIONS/GET responses.ellaEntityGraph()inapp/entity.json/route.ts, and make the human-readable MCP docs page (app/system/mcp/page.tsx) drive content from the registry constants; addMCP_ALLOWED_ORIGINSto.env.example.tests/mcp.test.tsexercising CORS, content negotiation, JSON-RPC behavior, tools and resources semantics, and canonical URL parity; updatepackage.jsonwith test and dependency changes and add CI workflow/.github/workflows/ci.yml; add deployment checklistdocs/mcp-deployment.md.Testing
npm run lintand typecheck vianpm run typecheckas part of CI; both checks succeeded.npm test(configured asnode --import tsx --test tests/*.test.ts), which executedtests/mcp.test.tscovering CORS, OPTIONS/GET behavior, content-negotiation, tools list/calls, resources read, and canonical URL parity; tests passed.npm run buildin CI and the build completed successfully.npm ci,npm run lint,npm run typecheck,npm test, andnpm run buildon pushes and PRs tomain.Codex Task