Feature/arp responder tx serializer - #6
Open
JaydenWong27 wants to merge 3 commits into
Open
JaydenWong27 wants to merge 3 commits into
JaydenWong27 wants to merge 3 commits into
Conversation
gjrchen
previously approved these changes
Jul 20, 2026
gjrchen
left a comment
gjrchen
left a comment
There was a problem hiding this comment.
Minor style comments mostly.
Have another member of the team look this over and reason about it before merging it :)
gjrchen
self-requested a review
August 2, 2026 21:21
gjrchen
approved these changes
Aug 2, 2026
gjrchen
left a comment
gjrchen
left a comment
There was a problem hiding this comment.
This is good quality, thanks for addressing the nitpicks.
Up to you if you want to push this into main or leave it out to deal with later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Created Testbench and module for tx serializer