Skip to content

Fix clippy lints and add pre-commit hooks - #10

Merged
Utagai merged 9 commits into
Utagai:masterfrom
LanHikari22:fix-clippy-lints-1
Sep 27, 2025
Merged

Fix clippy lints and add pre-commit hooks#10
Utagai merged 9 commits into
Utagai:masterfrom
LanHikari22:fix-clippy-lints-1

Conversation

@LanHikari22

@LanHikari22 LanHikari22 commented Aug 29, 2025

Copy link
Copy Markdown
Contributor
  • Added an additional note on update blocking on line read
  • Added small modifications to make sure all clippy lints pass
  • Add pre-commit hooks and documentation on its setup to ensure tests, formatting, and lints pass before commit
  • Fixed update signaling it can be reused when shell is terminated

It was previously failing in this github workflow job.

@LanHikari22 LanHikari22 changed the title Fix clippy lints Fix clippy lints and add pre-commit hooks Aug 29, 2025
@Utagai

Utagai commented Sep 4, 2025

Copy link
Copy Markdown
Owner

Just commenting here to say that I've seen the PR, but haven't had a chance to review. I will do so as soon as I can!

@Utagai Utagai left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Man, it is a little embarrassing to see some of my earliest Rust code from way back when. Thanks for going through and fixing/cleaning up a bunch of stuff. I put a few comments, but I don't think any of them are major.

Comment thread .pre-commit-config.yaml
Comment thread CONTRIBUTING.md Outdated
Comment thread README.md Outdated
Comment thread Cargo.toml Outdated
Comment thread src/command/help.rs
Comment thread src/shell.rs
Comment thread src/tokenizer.rs Outdated

@Utagai Utagai left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the recent changes.

The last things would be:

  • See my comment about _quotation; we should see if we can just remove that variable if its not doing anything useful.
  • Regarding tarpaulin, I'd see if you can figure out what the situation there is... ideally, we can just remove the lint rule and be fine, but if there's issues without that rule we should understand why.

This PR looks basically great to me minus the two items above, and both of those items are not dealbreakers.

For your information, I will be away on travel until 9/25. My responses in this PR may be delayed.

@Utagai Utagai left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay, but this looks great. Thanks!

@Utagai
Utagai merged commit 6ee3642 into Utagai:master Sep 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants