Skip to content

Skip non-generic osvvm packages when the simulator supports generics#769

Merged
LarsAsplund merged 1 commit intoVUnit:masterfrom
crdavis12:master
Oct 27, 2021
Merged

Skip non-generic osvvm packages when the simulator supports generics#769
LarsAsplund merged 1 commit intoVUnit:masterfrom
crdavis12:master

Conversation

@crdavis12
Copy link
Contributor

@crdavis12 crdavis12 commented Oct 26, 2021 •
edited
Loading

Fixes #768.

@umarcor umarcor mentioned this pull request Oct 26, 2021
Closed
@umarcor
Copy link
Member

umarcor commented Oct 26, 2021

/cc @abaebae

umarcor
umarcor approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@umarcor umarcor left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! https://github.com/OSVVM/OSVVM/blob/2021.09/osvvm.pro#L71-L78

@eine eine added this to the v4.7.0 milestone Oct 26, 2021
@eine eine requested a review from LarsAsplund October 26, 2021 16:30
@eine eine added the ThirdParty: OSVVM Related to OSVVM and/or OSVVMLibraries. label Oct 26, 2021
@LarsAsplund
Copy link
Collaborator

LarsAsplund commented Oct 27, 2021

Looks good. Tested locally and it works with GHDL, ModelSim, ActiveHDL, and Riviera-PRO.

@LarsAsplund LarsAsplund merged commit 3a81795 into VUnit:master Oct 27, 2021
@LarsAsplund LarsAsplund mentioned this pull request May 28, 2022
Closed
@umarcor umarcor mentioned this pull request Jun 23, 2022
Open
@crdavis12
Copy link
Contributor Author

crdavis12 commented Mar 16, 2023

Any chance of getting a 4.6.3 release with this fix included? Or is there a timeline for 4.7.0 soon-ish?
We're starting to get into a longer chain of limitations: Limited to vunit 4.5.0 to work with Riviera, vunit 4.5.0 doesn't work with Python 3.11 (fixed in 4.6.1 by #868). So that limits us to Python 3.10, which isn't a huge deal right now but will get more annoying as Python marches forward.

@umarcor
Copy link
Member

umarcor commented Mar 16, 2023

@crdavis12 see #918. We are releasing v4.7.0 as soon as we have some time to review the changelog/news and merge a couple PRs.

@crdavis12
Copy link
Contributor Author

crdavis12 commented Mar 16, 2023

Perfect! Thanks for the quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LarsAsplund LarsAsplund Awaiting requested review from LarsAsplund

1 more reviewer

@umarcor umarcor umarcor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ThirdParty: OSVVM Related to OSVVM and/or OSVVMLibraries.

Projects

None yet

Milestone

v4.7.0

Development

Successfully merging this pull request may close these issues.

Riviera fails to compile OSVVM 2021.09

4 participants

@crdavis12 @umarcor @LarsAsplund @eine