Skip to content

Improving regexs that scan attributes#836

Open
std-max wants to merge 1 commit intoVUnit:masterfrom
std-max:fix_parser
Open

Improving regexs that scan attributes#836
std-max wants to merge 1 commit intoVUnit:masterfrom
std-max:fix_parser

Conversation

@std-max
Copy link
Contributor

@std-max std-max commented May 31, 2022

Fix #670

@std-max
Copy link
Contributor Author

std-max commented May 31, 2022

Apparently a check failed but @LarsAsplund you have already fixed it in #835

@LarsAsplund
Copy link
Collaborator

@std-max Yes, the latest version of Sphinx is a new major version and comes with some backward compatibility breaking changes which I fixed. That is shortly on the master branch and then you can rebase.

@std-max
Copy link
Contributor Author

std-max commented May 31, 2022

CI looks good after rebasing :)

@eine eine added this to the v4.7.0 milestone Jun 1, 2022
@umarcor
Copy link
Member

umarcor commented Jun 1, 2022

@std-max do you mind adding some test to make this fix is necessary? I.e., the test should fail without this commit, but pass with it.

@std-max
Copy link
Contributor Author

std-max commented Jun 14, 2022

Yes, I will add some tests when I have a bit of time 👍

@eine eine modified the milestones: v4.7.0, v4.8.0, v5.0.0 Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VUnit fails to parse file with commented code

4 participants