Add postprocessor slot selection to AskCustom#469
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| def test_postprocessor_slot_invalid_value(): | ||
| with pytest.raises(ValueError): |
There was a problem hiding this comment.
[P1] Expect Pydantic ValidationError for invalid enum input
The invalid enum case in test_postprocessor_slot_invalid_value asserts that constructing AskCustom with a bad value raises ValueError, but AskCustom is a BaseModel and Pydantic emits a ValidationError when the enum check fails. As written the test will always fail even though the model behaves correctly. Please assert pytest.raises(ValidationError) (or have the model re‑raise) so the test matches the actual API behavior.
Useful? React with 👍 / 👎.
2 participants
Summary
PostprocessorSlotenum for available postprocessor systemsAskCustomto specifypostprocessor_slotTesting
python -m pip install -r requirements.txtpytesthttps://chatgpt.com/codex/tasks/task_e_68b9808975c483329888659d7a4256b1