-
Notifications
You must be signed in to change notification settings - Fork 16
Add postprocessor slot selection to AskCustom #469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
werk24
merged 1 commit into
main
from
codex/add-postprocessor_slot-attribute-to-askcustom
Sep 4, 2025
+35
−1
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| import pytest | ||
|
|
||
| from werk24 import AskCustom, PostprocessorSlot | ||
|
|
||
|
|
||
| def test_postprocessor_slot_default_none(): | ||
| ask = AskCustom(custom_id="foo") | ||
| assert ask.postprocessor_slot is None | ||
|
|
||
|
|
||
| def test_postprocessor_slot_enum_value(): | ||
| ask = AskCustom(custom_id="foo", postprocessor_slot=PostprocessorSlot.GREEN) | ||
| assert ask.postprocessor_slot == PostprocessorSlot.GREEN | ||
|
|
||
|
|
||
| def test_postprocessor_slot_invalid_value(): | ||
| with pytest.raises(ValueError): | ||
| AskCustom(custom_id="foo", postprocessor_slot="red") | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[P1] Expect Pydantic ValidationError for invalid enum input
The invalid enum case in
test_postprocessor_slot_invalid_valueasserts that constructingAskCustomwith a bad value raisesValueError, butAskCustomis aBaseModeland Pydantic emits aValidationErrorwhen the enum check fails. As written the test will always fail even though the model behaves correctly. Please assertpytest.raises(ValidationError)(or have the model re‑raise) so the test matches the actual API behavior.Useful? React with 👍 / 👎.