Fix message entries stored as 'track' instead of 'message' entry type#239
Open
jakebromberg wants to merge 7 commits intomainfrom
Open
Fix message entries stored as 'track' instead of 'message' entry type#239jakebromberg wants to merge 7 commits intomainfrom
jakebromberg wants to merge 7 commits intomainfrom
Conversation
added 5 commits
March 18, 2026 14:34
When a talkset, breakpoint, or other message was posted to the flowsheet, the controller did not set entry_type on the NewFSEntry, causing it to default to 'track' in the schema. This broke the V2 transform which relies on entry_type to determine the response shape. Now explicitly sets entry_type: 'message' for the message code path.
The test was asserting the buggy behavior where message entries were stored as 'track' type and returned with null metadata fields. Now that the fix correctly stores them as 'message' type, the V2 transform returns them without metadata fields (undefined, not null).
Infer the correct entry_type from message content instead of always using 'message'. Messages containing 'Talkset' are stored as entry_type 'talkset', messages containing 'Breakpoint' as 'breakpoint', consistent with the FlowsheetEntryType discriminated union defined in wxyc-shared's API spec.
Update addEntry tests to expect 201 (matching the recent controller change). Remove duplicate WxycError import in flowsheet.service.ts introduced by merge.
jakebromberg
force-pushed
the
bugfix/talkset-entry-type
branch
from
8310d29 to
2b898d2
Compare
added 2 commits
March 18, 2026 14:43
Allow callers to specify entry_type directly instead of relying solely on message content inference, falling back to inferMessageEntryType for backwards compatibility.
AyBruno
approved these changes
Mar 18, 2026
This was referenced Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
entry_type: 'message'explicitly when creating flowsheet entries from the message code path (talksets, breakpoints, PSAs, etc.)Closes #238