Repository navigation
Fix registered local models missing from the chat picker - #40
Merged
Merged
Conversation
Registration now upserts the shared Ollama provider with usable defaults, turns the local service flag on, and notifies the conversation picker so desktop GGUF/Ollama tags can be selected and routed to 11434. Unreachable Ollama shows an actionable error instead of a silent no-op. Co-authored-by: XYAI Labs <haoboy8@gmail.com>
Co-authored-by: XYAI Labs <haoboy8@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause
Model-page register (Ollama tag / GGUF) could succeed while the conversation picker still could not list or invoke those models.
Three separate gaps stacked:
GET /providers/resolvedandProviderStore.is_model_ref_usable, so the picker never showed them (or send rejected the ref).ollama(kind=ollama) without enabling it; GGUF register wroteOllama (Local). LocalServiceCard created a third row with all models disabled andenabled=false. Chat never saw a usable local catalog./modelsAPI (404), so the UI treated a successful backend register as “need provider”.PR #30 only fixed Windows register 500s. This change wires register → catalog → picker → harness
127.0.0.1:11434.What changed
upsert_ollama_modelis the single write path: enable the Ollama row, fillapi_key=ollama+http://127.0.0.1:11434/v1, mark the model enabled, setollama_service_enabled.list_resolved_models/ProviderStorefill those defaults so local refs are listed, usable, and built into harness configs.ollama/<tag>aliases resolve to the existing local row.octop:models-changedafter Models-page register/install.stream_errors.local_runtime(zh+en) with a link to/models, not a silent no-op.How to verify
11434). If the daemon is stopped, the UI shows the start-Ollama guidance.Local verification
uv run ruff check src tests— passeduv run pytest tests/unit— 2953 passed, 4 skippednpx vitest runon chatStreamError / presetUtils / LocalHardwarePanel / ChatInputActionsRow — 17 passedmypy --stricton touched provider modules — cleannpx tsc --noEmit— cleanChecklist