Fix Cloud uploads, sign-in persistence, and sync refresh - #22
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cloud uploads could send empty bodies on iOS, long publications could time out after 30 seconds, and restarting the app could lose a saved Cloud sign-in. This fixes the native adapters, recovers credentials stored under the old Secure Storage prefix, and adopts the shared 2.50.0 publishing, conflict, and restore fixes from ZenNotes/zennotes#774.
Validation: 93 tests pass; TypeScript, production web build, Capacitor sync, and signed iOS simulator build pass. Live native testing against zennotes.org covered sign-in/restart, automatic bidirectional sync, exact-hash 8.1 MB and 10,000,000-byte uploads, oversized-file recovery, publishing and updating the same URL (including Cloud Settings), offline conflict resolution, backup, restore, and unpublish. The final rebuild retained sign-in and received an Android-initiated restore: all eight files matched the checkpoint across iPhone, Android, and desktop, and a newer file disappeared on all three. Disposable Cloud resources were removed afterward.
Targets the existing
release/1.9.9baseline so this PR contains only the three Cloud fix commits. Shared source is pinned to104416f560bb9e709620cabe9e1f225306f7a4ea. Native validation used a simulator; five-minute timeout forwarding is tested without deliberately slowing the live service for five minutes.