Quick band-aid fix for always visible 1-2 pixel bar#22
Open
StefanOyx wants to merge 2 commits into
Open
Conversation
Zidras
requested changes
Dec 15, 2023
| function ZUF.HealthClipFrame_HealComm(frame) | ||
| if frame.HealCommBar then | ||
| ZUF:SetAlpha_HealComm(frame.HealCommBar, 1) | ||
| ZUF:SetAlpha_HealComm(frame.HealCommBar, 0) --xD changed from 1 to 0 to start it off hidden avoiding bug yet still have it there so it still positions properly |
Owner
There was a problem hiding this comment.
This breaks raid frame prediction, and I also find this not to be an adequate change since it affects bar creation
| absorbBar:SetAlpha(1) | ||
| overAbsorb:SetAlpha(1) | ||
| end | ||
|
|
Owner
There was a problem hiding this comment.
This would fail if you had one of the IncHeals present. Ideally, for the bandaid to work, I assume you'd have to check the Incoming value for 0 and AlphaHide the respective bar
| end | ||
|
|
||
| -- xD end of shit code | ||
|
|
Owner
There was a problem hiding this comment.
Same here, not all bars are absorb
Perhaps this method is a bit more robust than previous to avoid assumptions that are not always true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've commented as best I can, -- xD is where I made changes. Hope you can figure out a much cleaner way to fix this after taking a closer look.