Skip to content

Quick band-aid fix for always visible 1-2 pixel bar #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StefanOyx wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Quick band-aid fix for always visible 1-2 pixel bar #22

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ccd4be
Quick band-aid fix for always visible 1-2 pixel bar
StefanOyx Sep 5, 2023
bb51681
Specify elements to be Alpha'd based on value == 0
Zidras Dec 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion ElvUI_ProjectZidras/Modules/UnitFrames/Elements/HealPrediction.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,12 +272,14 @@ function ZUF:Configure_HealComm(frame)
end
end

function ZUF:UpdateHealComm(_, myIncomingHeal, otherIncomingHeal, absorb, _, hasOverAbsorb, hasOverHealAbsorb, health, maxHealth)
function ZUF:UpdateHealComm(_, myIncomingHeal, otherIncomingHeal, absorb, healAbsorb, hasOverAbsorb, hasOverHealAbsorb, health, maxHealth)
local frame = self.frame
local db = frame and frame.db and frame.db.healPrediction
if not db or not db.absorbStyle or not health then return end

local pred = frame.HealCommBar
local myBar = pred.myBar
local otherBar = pred.otherBar
local healAbsorbBar = pred.healAbsorbBar
local absorbBar = pred.absorbBar
local overAbsorb = pred.overAbsorb
Expand All @@ -303,6 +305,15 @@ function ZUF:UpdateHealComm(_, myIncomingHeal, otherIncomingHeal, absorb, _, has
local missingHealth = maxHealth - health
local healthPostHeal = health + myIncomingHeal + otherIncomingHeal

-- code fix by StefanOyx to visually hide heal and absorb bar if it is empty avoiding the 1 pixel line they each have by default in that state. Can prob be placed in a better position and fixed in a much better way.
-- This fix is inspired by ElvUI's default function "UpdateFillBar" in their HealComm.lua, they use "if amount == 0 then bar:Hide()" there to do the same thing, calling it on UpdateHealComm. The reason I used SetAlpha instead is
-- that for Zidras UpdateHealComm using :Hide() breaks bar positioning.

myBar:SetAlpha(myIncomingHeal == 0 and 0 or 1)
otherBar:SetAlpha(otherIncomingHeal == 0 and 0 or 1)
absorbBar:SetAlpha(absorb == 0 and 0 or 1)
healAbsorbBar:SetAlpha(healAbsorb == 0 and 0 or 1)

@Zidras Zidras Dec 15, 2023

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here, not all bars are absorb

-- handle over heal absorbs
healAbsorbBar:ClearAllPoints()
healAbsorbBar:Point(pred.anchor, frame.Health)
Expand Down