fix(proxy): drain queued data before propagating half-close - #223
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix transparent-proxy truncation when a peer half-closes while unread bytes remain.
Reproduction
Verified on master
4ff67c3770cb2dabc6f1427ef19277df093aafc1with real loopback TCP sockets:The fixed handler forwards all 65,536 bytes before propagating EOF. The peers remain open until their receive loops observe EOF.
Regression coverage
The existing proxy test binary now exercises the production C event loop through an internal test bridge, without exposing test hooks in production headers.
Validation
This branch is based directly on current master and contains no performance-experiment changes.