Conversation
Thanks! (I had no idea that my comment would show up on the pull request page). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, as we discussed in #44 and #43 this pull requests adds an gitab_api_version variable so the user can still decide to use the v3 api.
I only tested the resources which are in use in my infrastructure so api version v4 with git_deploy_key and git_webhook, so other resources and the v3 compatibility still needs testing.
Also if we are going to merge something like this we need to have a warning for users that are still using gitlab with api v3 to set gitlab_api_version to v3 when upgrading the module.