Repository navigation
feat(handoff): add private correlation ledger and evidence CLI - #107
Conversation
|
Review findings corrected and propagated through the implementation candidates. All three Draft PRs now target main; each exact current head has successful macOS/Linux Node22/24, Windows Node22/24, release gate, CodeQL (Actions and JavaScript/TypeScript) and GitGuardian checks.
Combined focused build/types and45/45 fixtures pass locally. main-target exact-head CI/CodeQL success supersedes the earlier stacked-base gate note. Implementation release gates and Draft status remain; no merge/publication performed. Dependency review order stays #106 -> #107 -> #108 -> #109 despite their main comparison targets. |
16cbd25 to
6363cb7
Compare
6363cb7 to
5a0323d
Compare
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5a0323d9c3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 746ce8b31b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Current review correction checkpoint — 2026-10-18 KST
Exact head
5b878fc8cc8a5120af5870a56156f8ae769bc6b8fixes the three additional current-head findings:ledger.key, bound to epoch/intent ID. Missing/changed/untrusted keys and old plaintext journals fail closed without automatic migration. Checksums/quota use ciphertext. A reader of both files is outside this journal-only protection.Local macOS arm64 Node24.16.0: focused71/71; full273 total /268 pass /0 fail /5 Windows-only skips. Build, types, package/reproducible isolated install/uninstall, shorthand, repository and diff checks pass. These are fixtures, not new native/model/SSH-host/ACK qualification. Frozen design bytes, runtime version and published skill pin remain unchanged. Earlier checkpoints below are history.
Converted Draft while correcting, then Ready on this exact head for fresh automatic reviews. Current-head CI/CodeQL and Code/Security reviews remain merge gates; no manual review mention or bypass. User-authorized order106→107→108→109; release preparation only, no publication.
Review correction checkpoint — 2026-10-17 KST
Exact head
746ce8b31b1b08540d9021b73aa2e0f9e9e060d1addresses all three P2 findings on5a0323d. Source behavior is narrower/moreconservative, not a scope extension:Original regression evidence: ledger2fail/1pass, inactivebinding2changedcasesfailed whileunchangedcontrolpassed, validator2fail. Afterfix focused54/54, full256total/251pass/0fail/5Windows-onlyskips, build/types, package/reproducibleinstall/uninstall, shorthand/repository/diff checks passed. No native/userdelivery/ACK test. Sourceandnewtests are six files; frozencontractbytes/version/skillpin unchanged.
Converted Draft while correcting then Ready onthisnewhead to trigger freshautomaticCode/Securityreviews withoutmanualmentions. CurrentheadCI/reviews are newgates; older12/12results do not qualifythisfix. Normalexact-headsquashmerge waitsforthem. CompanionguidancecandidatePR37 isnowavailableforcontentreview; it isnot a publishedskill orfinalprofileapproval.
Authorized sequential merge checkpoint — 2026-10-17 KST
User-authorized sequence106→107→108→109 and0.4release preparation. This supersedes earlier Draft/no-merge checkpoints below; publication remains a separate step.
5a0323d9c31572fe75f8ea2c0b32784f1adf2fe9; applies only107's12owncommits after actual106squash81d1aece70b414b6aef00641076bd2716f630f6e.Earlier history (superseded source/status checkpoints)
Current refresh checkpoint — 2026-10-14 KST
Exact head:
6363cb7d9b86d7eacf0ad2a2e3c51325d50230c8; latest published main base:a2057940ba19056fcaaa5551a7820f7414bd3bfa.Rebased sequentially in dependency order docs(handoff): record the jointly frozen v1 design #106 → feat(handoff): add private correlation ledger and evidence CLI #107 → feat(app-server): add bounded guarded queue-only client #108 → feat(observation): add scoped metadata projection and bounded local waits #109. Each PR keeps base
mainfor current-head full CI and CodeQL; later branches contain the preceding source dependencies and must be reviewed/merged in that order. This is branch preparation, not an integration merge into main.Local macOS arm64 checks: 246 total; 241 passed; zero failed; five Windows-only skips. Scoped handoff 14/14; build, types, repository/diff and reproducible package/install/uninstall checks passed. An initial run failed the old 0.3.3 SSH fixture banner; the final head corrects it to 0.3.5 and the full rerun passed.
Conformance used the existing exact exported published Python 1.1.0 source
8ca77cf31254c8287a2593fe484bb30a7dba2727; hash-pinned oracle tests executed. Frozen contract bytes/hashes and historical validation records are preserved.Published 0.3.5 version, finite skill matrix/pin, strict ordinary SSH response handling and Windows exit propagation are retained. No new native/live delivery, automated ACK or Linux/Windows observer qualification is claimed.
Current-head Actions completed successfully; automatic reviews remain a separate gate. Earlier green checks below are historical and do not verify this refreshed head. Draft, human review gate, no merge/tag/release/publication.
Final exact-head CI: 12/12 SUCCESS, CLI 38488648720 and CodeQL 38488644825, including both Windows-native Node 22/24. No rerun/bypass. Branch-scoped CodeQL open-alert API returned zero alerts. No new automatic Code/Security Review completion is claimed. GitHub reports MERGEABLE; the PR remains Draft.
Earlier PR history (superseded heads/checkpoints)
Scoped 0.4.0 review coordination — 2026-10-11 KST
The user approved keeping #69/#70/#71/#72 together with narrowly qualified macOS arm64 observation and explicit operator-confirmed receipts. Linux observation #130, Windows observation/private storage #131 and voluntary receipt producer/authenticated collector bootstrap #132 are Future extensions. No automatic ACK from text/turn/queue deletion, resend or receiver dedup is claimed. Required unsupported goals still refuse before effect.
This PR's own head remains
16cbd25e5bc254f3e7b7351d3dd4f2c2bbd8f73cand its narrower source/evidence below is unchanged. Integrated scope/docs and added pure-validator/ACK/SSH tests are in PR #109 atd830ccaa1a459bfec0f3c67e2b0e682d99bc7734; that integration does not retroactively qualify this standalone head. Companion skill guidance remains pending in session-peer-skill #31. Human review/merge order remains #106 → #107 → #108 → #109 with current-main checks. No merge/version bump/tag/release/publication is performed by this coordination.Current verification checkpoint — 2026-10-11
Head:
16cbd25e5bc254f3e7b7351d3dd4f2c2bbd8f73c. The ordinary conformance reference now pins published Python 1.1.0 at8ca77cf31254c8287a2593fe484bb30a7dba2727; selected source hashes are checked before conformance tests. The ordinary list/discovery comparison does not establish full handoff, receipt or SSH runtime parity.The published handoff document and fixture are byte-identical to frozen design commit
99d8ec3855d57da34a6fa789f3a375820a8fbe85. Fixture SHA-256 is963b94e78f510c2535e405813558275d512a5bfe6bbd99ffdf0994b4d2e6e441. Any older checkpoint claiming a different published fixture hash or changed negative vectors is superseded. Frozen bytes and the historical Python 1.0.3 design baseline are unchanged.Local Node 24.16.0/macOS arm64: build and type checks passed;
npm test: 241 total / 236 passed / 5 Windows-only skipped, zero failures. Package smoke, bash/zsh shorthand contract/lifecycle, repository metadata/links and diff checks passed. Current-head Actions are pending after this push; prior green checks are not presented as new-head success. Draft and human merge gate remain in place. No version bump, merge, tag, release, global installation or publication.Earlier checkpoints (history)
Current checkpoint — 2026-10-11 KST
Exact head:
df90a2cf9578bd56965a8ce7e44ef0058cbab670. Refreshed against published 0.3.3 mainc0ed30273b9e9c0049df86ae3c38486a94289527using fast-forward branch updates and integration merges; the earlier Cloud CodeQL fixes are retained. This stays Draft, refs #70, within the unchanged four-issue 0.4.0 milestone.Changes in this checkpoint
Classify each concurrent receipt/confirmation wait against its own cutoff, preserve immutable terminal waits, and reject receipt ordering when an older pending wait has an unprovable restarted clock. Validate archived waits independently of the latest operation actions. Align the unsolicited-SSH-evidence fixture with the current exact-version gate, and feed stdin only to the fixture command that actually consumes it.
Validation actually performed
47c23713d0a2a3c11ebde6186afd8c43489b8b65, extracted from the local reference repository. No runtime/reference repin.npm test(including build and test:types): 241 tests, 236 pass, 0 fail, 5 Windows-only skips.npm run test:package: bash/zsh contract + in-place fixture-version lifecycle, reproducible package, isolated install/uninstall pass. Repository checker, release helperpack/artifact,npm audit(0 vulnerabilities) and diff check pass. These are unpublished validation tarballs, not the public 0.3.3 bytes.Remaining gates
Automated receipt producer/collector bootstrap, generation-safe native ACK qualification, Windows private ACL storage and original-sender SSH coordination remain unsupported.
Required unsupported goals refuse before native effect. No fallback/retry after a possible native submission; queued/posted is not receipt ACK or completion. The milestone remains incomplete. No merge, release/version bump, npm publication, tag, protection change, operations change or issue closure is requested by this checkpoint.
Earlier implementation/validation record (historical checkpoint)
Scope
Refs #70 and #69. Part of 0.4.0; Draft, not a release or a claim of completed automated ACK support. Stacked on the exact jointly frozen design in #106. The vendored normative document/fixture hashes and historical runtime reference remain unchanged.
Validation
macOS arm64, Node 24.16.0; pinned existing Python reference 47c2371.
Remaining implementation gates
Production receipt producer/collector bootstrap, restart-safe Claude generation, Windows private ACL support, original-sender SSH ledger coordination, full operation setup cancellation and live/platform qualification remain open. CLI ACK therefore remains unsupported unless an independently qualified internal producer has minted authority; the CLI does not mint such authority. This PR does not close #70 or split the milestone. No merge/stage/tag/fleet changes.
Latest head:
9ae30ebf12909a0b2dd6eb34c12cf10adf83ef28; all eight CLI jobs and GitGuardian success. Stacked-base CodeQL remains a main-retarget gate.