Repository navigation
fix(deps): reject malformed TOML exponents in 0.5.1 - #164
Merged
Merged
Conversation
Closes #163. Pin smol-toml1.9.1, keep malformed configuration uncertain before submission, and preserve the finite skill profile and exact-version SSH contracts.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
smol-toml@1.9.0accepts malformed exponents such asnumeric_setting = 3e++20as a number. Configuration inspection could therefore report the default Codex storage layout instead of treating that configuration as unreadable. Pin the upstream 1.9.1 fix: doctor now reportsunknown / codex_config_unreadable, and dry-run/send refuse before the fixture queue is executed.Closes #163. Prepare package/banner/current examples for 0.5.1, carrying forward exactly the four skill profiles accepted by 0.5.0. Preserve historical rows, immutable skill pins and exact-version SSH. Unrelated runtime, native bindings, development/transitive dependencies and unsupported platform/ACK cells are unchanged. Open experimental/reporter PRs and the deferred #155 harness are not included.
This is a reproduced parser correctness fix. No published CVE or actual storage-relocation bypass is claimed. The current advisory audit reports zero vulnerabilities; upgrading unrelated packages solely because a newer version exists is outside this hotfix.
Upstream: https://github.com/squirrelchat/smol-toml/releases/tag/v1.9.1
Validation
npm audit: zero vulnerabilities.npm audit signatures: six packages verified, two provenance attestations verified. No live-agent/model/remote-host/global-install experiments.Release gates
Preparation baseline before staging: latest=0.5.0, preview=0.1.0-preview.1; 0.5.1 absent. Release source must be the exact reviewed merged main with successful CI. Authenticated owner lookup and no pending npm stages were confirmed. Fresh authenticated Trusted Publisher lookup confirms this repository,
publish.yml, environmentnpm, and onlycreateStagedPackage. The user explicitly skipped this 0.5.1 browser-only publish-MFA policy lookup, so that setting is not freshly audited; no historical exception is reused. GitHub npm environment remains reviewer-protected and main-only. Exact-source approval, protected-environment approval and final npm stage2FA were subsequently completed. Publication is verified below.Current-head CI/review
Final head
4004290462195acbc3cd7cf0de133f0e60190f59: all 12 checks pass in CLI run 40429016178, plus CodeQL/GitGuardian. An obsolete initial-head run was canceled after the documentation-only follow-up; its partial results are not the final gate.Automatic Code Review and Security Review completed without findings on
62ef9ba9ba7103e62843f9f4f72606ebae3da2bf. The final commit changes only nine RELEASING.md lines recording the fresh settings checks/user exception; executable code, dependency lock and tests are byte-identical to that automatically reviewed source. A separate read-only subagent reviewed the complete final4004290source/fixture/docs delta and found no remaining mandatory item. No automatic current-head review is claimed for4004290, and no manual mention was posted.The exact final archive reproduces with publishing npm11.15.0 and local npm11.19.1: SHA-256
09ad128c3ced31fa263008abd8683f6b60d7593183b36b72b334c1463192221c; all 18 packaged Markdown files match source. A fresh archive install passed five malformed/valid/configured storage predicates with parser1.9.1 and was removed. This is candidate evidence; merged source and Actions bytes are checked separately before publication.Merged-source preparation and publication
Merged as
90481b148584926ea328ed956327f3050d9be9cb; its Git tree equals reviewed4004290. Exact-main CLI 40429686245 and CodeQL 40429686223 completed successfully. Merged-source npm11.15.0 reproducible archive matches the reviewed SHA-256 above, with isolated installation/removal and unchanged 77-member selection. The approved source was staged once in run40430300541 and publicly published after the separate human gates.Public 0.5.1 — 2026-10-27 KST
npm0.5.1 and GitHubv0.5.1 are public from
90481b148584926ea328ed956327f3050d9be9cb. Annotated tag object385a06804faf9a351f3852bc8809e8583f251051peels to that source. Reviewed/Actions/staged/public tarballs match SHA-25609ad128c3ced31fa263008abd8683f6b60d7593183b36b72b334c1463192221c; latest=0.5.1 and preview=0.1.0-preview.1 is preserved. Pinned npm11.15.0 signature/provenance audit, fresh public install/version/empty discovery/removal and SLSA source/run/subject linkage passed. Stage498574f9-5ea9-442c-b609-2ffec44867e5is no longer pending; no second upload or fleet/global installation occurred. The browser package-MFA settings lookup exception remains explicit.