[mlir][dxsa] Fix attribute type of dxsa.index.rel.imm#162
Open
asavonic wants to merge 1 commit into
Open
Conversation
dxsa.index.rel.imm corresponds to D3D10_SB_OPERAND_INDEX_IMMEDIATE32_PLUS_RELATIVE, so it should have a 32-bit integer attribute for an immediate. There is also D3D10_SB_OPERAND_INDEX_IMMEDIATE64_PLUS_RELATIVE defined in the header, but the original compiler does not support it, so we omit it as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dxsa.index.rel.immcorresponds toD3D10_SB_OPERAND_INDEX_IMMEDIATE32_PLUS_RELATIVE, so it should have a 32-bit integer attribute for an immediate.There is also
D3D10_SB_OPERAND_INDEX_IMMEDIATE64_PLUS_RELATIVEdefined in the header, but the original compiler does not support it, so we omit it as well.