Skip to content

[mlir][dxsa] Fix attribute type of dxsa.index.rel.imm #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
asavonic wants to merge 1 commit into
base: dxsa-mlir
Choose a base branch
from
Open

[mlir][dxsa] Fix attribute type of dxsa.index.rel.imm #162

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mlir/include/mlir/Dialect/DXSA/IR/DXSAOps.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ def DXSA_IndexRelImm : DXSA_Op<"index.rel.imm"> {
TODO
}];

let arguments = (ins DXSA_OperandType:$operand, StrAttr:$op, I64Attr:$imm);
let arguments = (ins DXSA_OperandType:$operand, StrAttr:$op, I32Attr:$imm);
let results = (outs DXSA_IndexType:$index);
let assemblyFormat = "$operand attr-dict";
}
Expand Down
Binary file added mlir/test/Target/DXSA/inputs/mov_index_rel_imm.bin
View file
Open in desktop
Binary file not shown.
13 changes: 13 additions & 0 deletions mlir/test/Target/DXSA/mov_index_rel_imm.mlir
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
// RUN: mlir-translate --import-dxsa-bin %S/inputs/mov_index_rel_imm.bin | FileCheck %s
// mov o0.xyzw, v[r0.x + 66][0].xyzw

// CHECK: module {
// CHECK-NEXT: %0 = dxsa.index.imm {imm = 0 : i32}
// CHECK-NEXT: %1 = dxsa.operand %0 {mask = 240 : i32, num_components = 4 : i32, type = 2 : i32}
// CHECK-NEXT: %2 = dxsa.index.imm {imm = 0 : i32}
// CHECK-NEXT: %3 = dxsa.operand %2 {num_components = 4 : i32, one = 0 : i32, type = 0 : i32}
// CHECK-NEXT: %4 = dxsa.index.rel.imm %3 {imm = 66 : i32, op = "add"}
// CHECK-NEXT: %5 = dxsa.index.imm {imm = 0 : i32}
// CHECK-NEXT: %6 = dxsa.operand %4, %5 {num_components = 4 : i32, swizzle = dense<[0, 1, 2, 3]> : vector<4xi32>, type = 1 : i32}
// CHECK-NEXT: dxsa.instruction "mov" %1, %6
// CHECK-NEXT: }