Skip to content

fixes issue 276#388

Open
razeprasine wants to merge 6 commits into
accesslayerorg:mainfrom
razeprasine:fix-issue-276
Open

fixes issue 276#388
razeprasine wants to merge 6 commits into
accesslayerorg:mainfrom
razeprasine:fix-issue-276

Conversation

@razeprasine
Copy link
Copy Markdown
Contributor

@razeprasine razeprasine commented Jun 2, 2026

Summary
Added deterministic test wallet address helpers scoped to the integration test helper module.
Updated an existing supply invariant test to use the new helper for multiple buyer addresses.
Added tests covering stable same-input address generation and distinct addresses for different inputs.

Testing

  • cargo fmt --all -- --check
  • cargo clippy --workspace --all-targets -- -D warnings
  • cargo test --workspace

Closes #276

Checklist

  • Linked issue or backlog item
  • Added or updated creator-keys unit/integration tests for every changed contract behavior
  • Ran cargo fmt --all -- --check, cargo clippy --workspace --all-targets -- -D warnings, and cargo test --workspace
  • Reviewed persistent storage changes against docs/storage-key-invariants.md
  • Confirmed event names, topic order, payload field order, and field meanings remain compatible with docs/contract-event-conventions.md
  • Updated docs for any changed public contract interface
  • Scope stays limited to one contract concern

@drips-wave
Copy link
Copy Markdown

drips-wave Bot commented Jun 2, 2026

@razeprasine Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@Chucks1093 Chucks1093 closed this Jun 2, 2026
@Chucks1093 Chucks1093 reopened this Jun 2, 2026
@Chucks1093
Copy link
Copy Markdown
Contributor

Hi @razeprasine, CI is failing on all three of your PRs because of a missing closing brace } in creator-keys/tests/contract_test_env/mod.rs.

The base32_encode function is not closed before the next function starts. Open that file and find the end of base32_encode — it returns encoded but is missing the closing brace. It should look like this:

    if bits > 0 {
        let index = ((buffer << (5 - bits)) & 0x1f) as usize;
        encoded.push(ALPHABET[index] as char);
    }

    encoded
}  // <-- this closing brace is missing

/// Computes the expected buy price...
pub fn compute_expected_buy_price(...

Add that } after encoded, run cargo fmt --all -- --check and cargo test --workspace to confirm, then push and CI should pass.

Also note: the PR body has been updated to include Closes #276 so the issue will auto-close when this merges.

This was referenced Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add helper for building deterministic test wallet addresses

2 participants