Use Locale.ROOT for identifier case conversions#149
Open
adamw7 wants to merge 1 commit into
Open
Conversation
Utils case-conversion helpers used the default locale. Under the Turkish locale, lower-casing 'I' produces a dotless 'ı' and upper-casing 'i' produces 'İ' — either one would emit an identifier that the Java compiler rejects, breaking codegen on Turkish-locale machines. These conversions are for Java source output, so they should always be locale-independent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Utils.firstToLower,firstUpper, andtoProperCasecalledString#toUpperCase()/toLowerCase()with the default locale. These helpers are used to build Java identifiers that are emitted into generated source. Under the Turkish locale,'I'.toLowerCase()yieldsı(dotless) and'i'.toUpperCase()yieldsİ— either one produces an identifier the Java compiler rejects.Pass
Locale.ROOTto every call so the output is deterministic across locales.Test plan
mvn installpasses-Duser.language=tr -Duser.country=TRand confirm identifiers now remain ASCII-lower/upper case